fix: prevent Maximum call stack size exceeded #3816
+342
−286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to INSERT a large amount of data at once causes a Maximum call stack size exceeded error.
In my case, it occurred with the following:
drizzle-orm/drizzle-orm/src/sql/sql.ts
Line 78 in 10d2230
The minimal code to reproduce this issue is as follows:
To address this issue, I added a
push_array
utility to prevent the error.Regarding performance, I believe the impact is negligible, but is there any benchmark data available to confirm this?
I’d like to add an ESLint rule to inspect the use of
array.push(...items)
in the future. What do you think? If you agree, I will create a separate PR for it.