New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept non-column first argument in between and notBetween conditions #3829

Open

acontreras89 wants to merge 2 commits into drizzle-team:main from acontreras89:feature/improved-between-conditions

+98 −52

acontreras89 commented Dec 23, 2024

Fixes #3624. Make between and notBetween conditions more versatile by not forcing the first argument to be a SQL wrapper.

This enables things like

between(new Date(), promotion.start, promotion.end)
between(sql`now()`, promotion.start, promotion.end)

acontreras89 added 2 commits

December 24, 2024 00:11


          Accept non-column first argument in between and notBetween conditions

fa2bf0e


          Update type tests

336a0bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet