Skip to content

Commit

Permalink
Merge pull request Ada-C6#2 from AdaGold/kab/templates
Browse files Browse the repository at this point in the history
Feedback Template
  • Loading branch information
kariabancroft authored Feb 24, 2017
2 parents 6d2e7c4 + 8d6aa9e commit e0e7409
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 10 deletions.
13 changes: 13 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Scrabble
Congratulations! You're submitting your assignment.

## Comprehension Questions

| Feature | Feedback |
|--- |--- |
| How do you feel you and your partner did in sharing responsibilities? | |
| Why do you think we chose to make the `score` method in the `Scoring` class a **class method** instead of an **instance method**? | |
| Describe an example of a test you wrote for a _nominal case_. | |
| Describe an example of a test you wrote for an _edge case_. | |
| What was your final test coverage percentage? | |
| Is there a specific piece of code you'd like feedback on? | |
24 changes: 14 additions & 10 deletions feedback.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,21 @@
| Answered comprehension questions | |
| Both Teammates contributed to the codebase | |
| Regular Commits with meaningful commit messages | |
| **Wave 1** | |
| `Scoring` class | |
| **Scoring class** | |
| `score` method | |
| Uses hash to store the alpha score | |
| Uses appropriate data structure to store the letter score | |
| Appropriately handles edge cases | |
| Tests `score` edge cases (one-letter word, 7 letter word) | |
| `highest_scoring_word` method | |
| Appropriately handling edge cases | |
| Appropriately handles edge cases | |
| Tests `highest_scoring_word` edge cases (ties, no words, no array) | |
| **Wave 2** | |
| `Player` class | |
| **Baseline** | |
| Readable code with consistent indentation. | |
| **Extras** | |

| **Player class** | |
| Uses an array to keep track of words played | |
| Uses existing code to create `highest_scoring_word` and `highest_word_score` | |
| Returns `true` or `false` from `won?` method | |
| Tests edge cases on the `play(word)` method for words that cannot be scored | |
| **TileBag class** | |
| Uses a data structure to keep the set of default tiles in the bag | |
| `draw_tiles` method uses the parameter to draw a set of random tiles | |
| `tiles_remaining` method returns a count | |
| Tests `draw_tiles` edge cases for different parameter inputs | |

0 comments on commit e0e7409

Please sign in to comment.