Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chai Colors #57

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Chai Colors #57

merged 2 commits into from
Aug 20, 2024

Conversation

janewaitara
Copy link
Contributor

@janewaitara janewaitara commented Aug 17, 2024


! Edit this before submitting your PR !(Remove this after editing)


name: Pull request
about: Create a pull request
label: 'triage me'
Fixes #56


How can this PR be tested?

Please describe how the reviewers can test your changes here. i.e To test it Log
off the internet


Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure your branch is up to date with develop branch.
  • Ensure your branch runs without breaking.
  • Ensure you solved any merge conflicts.
  • Smaller PRs for the ease of reviewing
  • Make sure to open a GitHub issue as a bug/feature request before writing your code! This means that we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass (./gradlew --init-script gradle/init.gradle.kts spotlessApply to automatically apply formatting)
  • Appropriate docs were updated (You are adding code so...)
  • Tests have been written

Is this your first Pull Request?

  • Run ./tools/setup.sh
  • Import the code formatting style as explained in the setup script.

Fixes #<issue_number_goes_here> 🦕

Screenshot

For PRs that change the UI, attach a before/after screenshot.
[REMOVE THIS SECTION IF IT DOES NOT APPLY TO THIS PR]

Copy link
Contributor

@MamboBryan MamboBryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamzi is this the way you were thinking the colors should be named and are we sticking to the tokens provided here @janewaitara ?

@tamzi tamzi merged commit 427e401 into main Aug 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colors
3 participants