Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#269 앱이름, 패키지 이름 수정 #270

Merged
merged 2 commits into from
Apr 5, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ plugins {
}

android {
namespace = "com.droidknights.app2023"
namespace = "com.droidknights.app"

defaultConfig {
applicationId = "com.droidknights.app2023"
applicationId = "com.droidknights.app"
versionCode = 1
versionName = "1.0"
}
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@
<uses-permission android:name="android.permission.INTERNET" />

<application
android:name=".DroidKnightsApplication"
android:name="com.droidknights.app.DroidKnightsApplication"
android:allowBackup="true"
android:dataExtractionRules="@xml/data_extraction_rules"
android:fullBackupContent="@xml/backup_rules"
android:icon="@mipmap/ic_launcher"
android:label="@string/app_name"
android:roundIcon="@mipmap/ic_launcher_round"
android:supportsRtl="true"
android:theme="@style/Theme.DroidKnights2023"
android:theme="@style/Theme.DroidKnights"
tools:targetApi="31">

</application>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023
package com.droidknights.app

import android.app.Application
import dagger.hilt.android.HiltAndroidApp
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<resources>
<string name="app_name">드로이드나이츠 2023</string>
<string name="app_name">드로이드나이츠</string>
</resources>
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023
package com.droidknights.app

import io.kotest.core.spec.style.StringSpec
import io.kotest.matchers.shouldBe
Expand Down
4 changes: 2 additions & 2 deletions build-logic/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ gradlePlugin {
plugins {
register("androidHilt") {
id = "droidknights.android.hilt"
implementationClass = "com.droidknights.app2023.HiltAndroidPlugin"
implementationClass = "com.droidknights.app.HiltAndroidPlugin"
}
register("kotlinHilt") {
id = "droidknights.kotlin.hilt"
implementationClass = "com.droidknights.app2023.HiltKotlinPlugin"
implementationClass = "com.droidknights.app.HiltKotlinPlugin"
}
}
}
1 change: 1 addition & 0 deletions build-logic/settings.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
enableFeaturePreview("TYPESAFE_PROJECT_ACCESSORS")
@Suppress("UnstableApiUsage")
dependencyResolutionManagement {
repositories {
google()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package com.droidknights.app

import org.gradle.api.Project

fun Project.setNamespace(name: String) {
androidExtension.apply {
namespace = "com.droidknights.app.$name"
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023
package com.droidknights.app

import org.gradle.api.Project
import org.gradle.kotlin.dsl.dependencies
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023
package com.droidknights.app

import org.gradle.api.Project
import org.gradle.kotlin.dsl.dependencies
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023
package com.droidknights.app

import com.android.build.api.dsl.ApplicationExtension
import com.android.build.api.dsl.CommonExtension
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023
package com.droidknights.app

import org.gradle.api.Plugin
import org.gradle.api.Project
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023
package com.droidknights.app

import org.gradle.api.Plugin
import org.gradle.api.Project
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
package com.droidknights.app2023
package com.droidknights.app

import org.gradle.api.Project
import org.gradle.kotlin.dsl.dependencies

internal fun Project.configureKotestAndroid() {
configureKotest()
configureJUnitAndroid()
}

@Suppress("UnstableApiUsage")
internal fun Project.configureJUnitAndroid() {
androidExtension.apply {
testOptions {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023
package com.droidknights.app

import org.gradle.api.Project
import org.gradle.api.tasks.testing.Test
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@file:Suppress("UnstableApiUsage")

package com.droidknights.app2023
package com.droidknights.app

import org.gradle.api.JavaVersion
import org.gradle.api.Project
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023
package com.droidknights.app

import org.gradle.api.Project
import org.gradle.kotlin.dsl.dependencies
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import com.droidknights.app2023.configureHiltAndroid
import com.droidknights.app2023.configureKotestAndroid
import com.droidknights.app2023.configureKotlinAndroid
import com.droidknights.app.configureHiltAndroid
import com.droidknights.app.configureKotestAndroid
import com.droidknights.app.configureKotlinAndroid

plugins {
id("com.android.application")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import com.droidknights.app2023.configureComposeAndroid
import com.droidknights.app.configureComposeAndroid

configureComposeAndroid()
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import com.droidknights.app2023.configureHiltAndroid
import com.droidknights.app2023.libs
import com.droidknights.app.configureHiltAndroid
import com.droidknights.app.libs

plugins {
id("droidknights.android.library")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import com.droidknights.app2023.configureCoroutineAndroid
import com.droidknights.app2023.configureHiltAndroid
import com.droidknights.app2023.configureKotest
import com.droidknights.app2023.configureKotlinAndroid
import com.droidknights.app.configureCoroutineAndroid
import com.droidknights.app.configureHiltAndroid
import com.droidknights.app.configureKotest
import com.droidknights.app.configureKotlinAndroid

plugins {
id("com.android.library")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import com.droidknights.app2023.configureKotest
import com.droidknights.app2023.configureKotlin
import com.droidknights.app.configureKotest
import com.droidknights.app.configureKotlin

plugins {
kotlin("jvm")
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import com.droidknights.app2023.configureVerifyDetekt
import com.droidknights.app.configureVerifyDetekt

configureVerifyDetekt()

Expand Down
4 changes: 3 additions & 1 deletion core/data/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import com.droidknights.app.setNamespace

plugins {
id("droidknights.android.library")
id("droidknights.android.hilt")
id("kotlinx-serialization")
}

android {
namespace = "com.droidknights.app2023.core.data"
setNamespace("core.data")
}

dependencies {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package com.droidknights.app2023.core.data.api
package com.droidknights.app.core.data.api

import com.droidknights.app2023.core.data.api.model.ContributorResponse
import com.droidknights.app.core.data.api.model.ContributorResponse
import retrofit2.http.GET
import retrofit2.http.Path

internal interface GithubApi {

@GET("repos/{owner}/{name}/contributors")
suspend fun getContributors(
@Path("owner") owner: String,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package com.droidknights.app.core.data.api

import com.droidknights.app.core.data.api.model.SessionResponse
import com.droidknights.app.core.data.api.model.SponsorResponse
import retrofit2.http.GET

internal interface GithubRawApi {

@GET("/droidknights/DroidKnightsApp/main/core/data/src/main/assets/sponsors.json")
suspend fun getSponsors(): List<SponsorResponse>

@GET("/droidknights/DroidKnightsApp/main/core/data/src/main/assets/sessions.json")
suspend fun getSessions(): List<SessionResponse>
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package com.droidknights.app2023.core.data.api.fake
package com.droidknights.app.core.data.api.fake

import android.content.Context
import com.droidknights.app2023.core.data.api.GithubRawApi
import com.droidknights.app2023.core.data.api.model.SessionResponse
import com.droidknights.app2023.core.data.api.model.SponsorResponse
import com.droidknights.app.core.data.api.GithubRawApi
import com.droidknights.app.core.data.api.model.SessionResponse
import com.droidknights.app.core.data.api.model.SponsorResponse
import kotlinx.serialization.ExperimentalSerializationApi
import kotlinx.serialization.json.Json
import kotlinx.serialization.json.decodeFromStream
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023.core.data.api.model
package com.droidknights.app.core.data.api.model

import kotlinx.serialization.SerialName
import kotlinx.serialization.Serializable
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023.core.data.api.model
package com.droidknights.app.core.data.api.model

import kotlinx.serialization.SerialName
import kotlinx.serialization.Serializable
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023.core.data.api.model
package com.droidknights.app.core.data.api.model

import kotlinx.serialization.SerialName
import kotlinx.serialization.Serializable
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023.core.data.api.model
package com.droidknights.app.core.data.api.model

import kotlinx.datetime.LocalDateTime
import kotlinx.serialization.Serializable
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023.core.data.api.model
package com.droidknights.app.core.data.api.model

import kotlinx.serialization.SerialName
import kotlinx.serialization.Serializable
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.droidknights.app2023.core.data.api.model
package com.droidknights.app.core.data.api.model

import kotlinx.serialization.SerialName
import kotlinx.serialization.Serializable
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.droidknights.app2023.core.data.di
package com.droidknights.app.core.data.di

import com.droidknights.app2023.core.data.api.GithubApi
import com.droidknights.app2023.core.data.api.GithubRawApi
import com.droidknights.app.core.data.api.GithubApi
import com.droidknights.app.core.data.api.GithubRawApi
import dagger.Module
import dagger.Provides
import dagger.hilt.InstallIn
Expand Down
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
package com.droidknights.app2023.core.data.di
package com.droidknights.app.core.data.di

import android.content.Context
import com.droidknights.app2023.core.data.api.GithubRawApi
import com.droidknights.app2023.core.data.api.fake.AssetsGithubRawApi
import com.droidknights.app2023.core.data.repository.ContributorRepository
import com.droidknights.app2023.core.data.repository.DefaultContributorRepository
import com.droidknights.app2023.core.data.repository.DefaultSessionRepository
import com.droidknights.app2023.core.data.repository.DefaultSettingsRepository
import com.droidknights.app2023.core.data.repository.DefaultSponsorRepository
import com.droidknights.app2023.core.data.repository.SessionRepository
import com.droidknights.app2023.core.data.repository.SettingsRepository
import com.droidknights.app2023.core.data.repository.SponsorRepository
import com.droidknights.app2023.core.datastore.datasource.DefaultSessionPreferencesDataSource
import com.droidknights.app2023.core.datastore.datasource.SessionPreferencesDataSource
import com.droidknights.app.core.data.api.GithubRawApi
import com.droidknights.app.core.data.api.fake.AssetsGithubRawApi
import com.droidknights.app.core.data.repository.ContributorRepository
import com.droidknights.app.core.data.repository.DefaultContributorRepository
import com.droidknights.app.core.data.repository.DefaultSessionRepository
import com.droidknights.app.core.data.repository.DefaultSettingsRepository
import com.droidknights.app.core.data.repository.DefaultSponsorRepository
import com.droidknights.app.core.data.repository.SessionRepository
import com.droidknights.app.core.data.repository.SettingsRepository
import com.droidknights.app.core.data.repository.SponsorRepository
import com.droidknights.app.core.datastore.datasource.DefaultSessionPreferencesDataSource
import com.droidknights.app.core.datastore.datasource.SessionPreferencesDataSource
import dagger.Binds
import dagger.Module
import dagger.Provides
Expand Down Expand Up @@ -48,19 +48,22 @@ internal abstract class DataModule {
@Singleton
fun provideSponsorRepository(
githubRawApi: GithubRawApi,
): SponsorRepository = DefaultSponsorRepository(githubRawApi)
): SponsorRepository =
DefaultSponsorRepository(githubRawApi)

@Provides
@Singleton
fun provideSessionRepository(
githubRawApi: GithubRawApi,
sessionDataSource: SessionPreferencesDataSource,
): SessionRepository = DefaultSessionRepository(githubRawApi, sessionDataSource)
): SessionRepository =
DefaultSessionRepository(githubRawApi, sessionDataSource)

@Provides
@Singleton
fun provideGithubRawApi(
@ApplicationContext context: Context,
): AssetsGithubRawApi = AssetsGithubRawApi(context)
): AssetsGithubRawApi =
AssetsGithubRawApi(context)
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.droidknights.app2023.core.data.mapper
package com.droidknights.app.core.data.mapper

import com.droidknights.app2023.core.data.api.model.ContributorResponse
import com.droidknights.app2023.core.model.Contributor
import com.droidknights.app.core.data.api.model.ContributorResponse
import com.droidknights.app.core.model.Contributor

internal fun ContributorResponse.toData(): Contributor =
Contributor(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
package com.droidknights.app2023.core.data.mapper
package com.droidknights.app.core.data.mapper

import com.droidknights.app2023.core.data.api.model.LevelResponse
import com.droidknights.app2023.core.data.api.model.RoomResponse
import com.droidknights.app2023.core.data.api.model.SessionResponse
import com.droidknights.app2023.core.data.api.model.SpeakerResponse
import com.droidknights.app2023.core.model.Level
import com.droidknights.app2023.core.model.Room
import com.droidknights.app2023.core.model.Session
import com.droidknights.app2023.core.model.Speaker
import com.droidknights.app2023.core.model.Tag
import com.droidknights.app.core.data.api.model.LevelResponse
import com.droidknights.app.core.data.api.model.RoomResponse
import com.droidknights.app.core.data.api.model.SessionResponse
import com.droidknights.app.core.data.api.model.SpeakerResponse
import com.droidknights.app.core.model.Level
import com.droidknights.app.core.model.Room
import com.droidknights.app.core.model.Session
import com.droidknights.app.core.model.Speaker
import com.droidknights.app.core.model.Tag

internal fun SessionResponse.toData(): Session = Session(
id = this.id,
Expand Down
Loading
Loading