Merge pull request #438 from Humsen/feature/20240712_jmx

[ISSUE 437]fix: 修复JMX重复注册报错
dromara · Jul 12, 2024 · a295a91 · a295a91
2 parents f139de0 + a618f35
commit a295a91
Showing 1 changed file with 21 additions and 7 deletions.
diff --git a/core/src/main/java/org/dromara/dynamictp/core/monitor/collector/jmx/JMXCollector.java b/core/src/main/java/org/dromara/dynamictp/core/monitor/collector/jmx/JMXCollector.java
@@ -21,11 +21,14 @@
 import org.dromara.dynamictp.common.em.CollectorTypeEnum;
 import org.dromara.dynamictp.common.entity.ThreadPoolStats;
 import org.dromara.dynamictp.core.monitor.collector.AbstractCollector;
+import org.springframework.beans.BeanUtils;
 
 import javax.management.JMException;
 import javax.management.MBeanServer;
 import javax.management.ObjectName;
 import java.lang.management.ManagementFactory;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
 
 /**
  * ThreadPoolStatsInfo related
@@ -37,15 +40,26 @@ public class JMXCollector extends AbstractCollector {
 
     public static final String DTP_METRIC_NAME_PREFIX = "dtp.thread.pool";
 
+    /**
+     * thread pool stats map
+     */
+    private static final Map<String, ThreadPoolStats> GAUGE_CACHE = new ConcurrentHashMap<>();
+
     @Override
     public void collect(ThreadPoolStats threadPoolStats) {
-        try {
-            MBeanServer server = ManagementFactory.getPlatformMBeanServer();
-            ObjectName name = new ObjectName(DTP_METRIC_NAME_PREFIX + ":name=" + threadPoolStats.getPoolName());
-            ThreadPoolStatsJMX stats = new ThreadPoolStatsJMX(threadPoolStats);
-            server.registerMBean(stats, name);
-        } catch (JMException e) {
-            log.error("collect thread pool stats error", e);
+        if (GAUGE_CACHE.containsKey(threadPoolStats.getPoolName())) {
+            ThreadPoolStats poolStats = GAUGE_CACHE.get(threadPoolStats.getPoolName());
+            BeanUtils.copyProperties(threadPoolStats, poolStats);
+        } else {
+            try {
+                MBeanServer server = ManagementFactory.getPlatformMBeanServer();
+                ObjectName name = new ObjectName(DTP_METRIC_NAME_PREFIX + ":name=" + threadPoolStats.getPoolName());
+                ThreadPoolStatsJMX stats = new ThreadPoolStatsJMX(threadPoolStats);
+                server.registerMBean(stats, name);
+            } catch (JMException e) {
+                log.error("collect thread pool stats error", e);
+            }
+            GAUGE_CACHE.put(threadPoolStats.getPoolName(), threadPoolStats);
         }
     }