[ISSUE #283] add Priority executor #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
加上 license header，ThreadPoolBuilder 里也加上吧 |
已做修改~ |
|
LGTM |
yanhom1314
reviewed
Jan 7, 2024
| Runnable po1 = ((DtpRunnable) o1).getOriginRunnable(); | ||
| Runnable po2 = ((DtpRunnable) o2).getOriginRunnable(); | ||
| if (po1 instanceof Priority && po2 instanceof Priority) { | ||
| return Integer.compare(((Priority) po1).getPriority(), ((Priority) po2).getPriority()); |
There was a problem hiding this comment.
这块应该用降序吧
类似@order,感觉用升序好点？
There was a problem hiding this comment.
也行，加点注释吧，不然容易理解不一致
好，已添加注释
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加优先队列