-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #301] 添加JMX监控采集类型 #390
Conversation
@Data | ||
@Builder | ||
@NoArgsConstructor | ||
@AllArgsConstructor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里需要构造函数,但是不知道加这两个注解(加了@builder原因)好还是新增一个类复制这些属性好
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没看到哪儿需要构造函数呢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没看到哪儿需要构造函数呢
MXBean 里面成员对象需要构造函数
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
了解了,要不去掉@builder吧,用的地方好像就一处
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
了解了,要不去掉@builder吧,用的地方好像就一处
OK,我改下
PTAL |
LGTM |
#301
![image](https://private-user-images.githubusercontent.com/16450524/295866086-d4986663-bfae-461e-82f4-1673c480c006.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM4ODk3MTIsIm5iZiI6MTcyMzg4OTQxMiwicGF0aCI6Ii8xNjQ1MDUyNC8yOTU4NjYwODYtZDQ5ODY2NjMtYmZhZS00NjFlLTgyZjQtMTY3M2M0ODBjMDA2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE3VDEwMTAxMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM2OWY5NTRjYTIwN2Y4MmJlMWY3ZTI2NjcxM2RmNzk3YjZlMjk1YzFlMjgwNTJiNGJhNjUzMzIxMGM3OWUxNjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.04pY38st39QltiF2y0kRJMaOz3Gm4aF-2V3ohPXVUzU)