-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue #1163 #1212
base: master
Are you sure you want to change the base?
Fixes issue #1163 #1212
Conversation
Thanks @mikkpokk, hopefully we can get this merged soon |
Related with dromru#1163 Keep in mind, usage actually stays the same. You can call `ref={ref}` as before.
Usage stays the same. You can use it as: <Gallery>
<Item key={key}
original={item.original}
thumbnail={item.thumbnail}
width={item.width}
height={item.height}>
{({ref, open}) => {
return (
<img src={item.thumbnail} ref={ref} />
)
}}
</Item>
</Gallery> OR <Gallery>
<Item key={key}
original={item.original}
thumbnail={item.thumbnail}
width={item.width}
height={item.height}>
{({ref, open}) => {
return (
<img src={item.thumbnail} ref={(node: HTMLImageElement) => {
// localCallback(node)
ref(node)
}} />
)
}}
</Item>
</Gallery> |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
+ Coverage 98.43% 98.48% +0.05%
==========================================
Files 16 16
Lines 255 264 +9
Branches 54 57 +3
==========================================
+ Hits 251 260 +9
Misses 4 4
☔ View full report in Codecov by Sentry. |
pages/deploy check failed due to permissions error. Please review. |
More info: #1163