Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [CDE-585]: Support creation and attaching of persistent disks #538

Merged
merged 12 commits into from
Feb 3, 2025

Conversation

vikyathharekal
Copy link
Collaborator

@vikyathharekal vikyathharekal commented Jan 28, 2025

Description

  1. Create Disk
    • Create (if required) and attach the persistent disk to the VM.
    • Wait for the disk to be created and then initiate instance creation.
    • Pass storage type (example: "pd-balanced")
    • storage_identifier supports a comma-separated list of identifiers, to support 2 separate disks (1 for gitspace and 1 for docker) in the future.
  2. Delete Disk
    • Delete the disk on Delete Gitspace (StorageCleanupType.DELETE).
    • Disk would retained in case of Stop Gitspace (StorageCleanupType.DETACH).
    • If the disk needs to be deleted, wait for instance deletion to complete and then hit the delete disk API.
    • Add storage_identifier in instance info (This will be sent in the destroy request to identify the disk and delete it)
    • Pass StorageCleanupType in VMCleanupRequest
  3. Skip CDE VMs from cleanup by setting "retain": true label

Commit Checklist

Thank you for creating a pull request! To help us review / merge this can you make sure that your PR adheres as much as possible to the following.

The Basics

If you are adding new functionality, please provide evidence of the new functionality.

raghavharness
raghavharness previously approved these changes Feb 3, 2025
Copy link
Collaborator

@raghavharness raghavharness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikyathharekal vikyathharekal merged commit ab30e8d into master Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants