Add retention message image support #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Chris Ballinger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
hughbromund
approved these changes
Oct 17, 2025
Comment on lines
+685
to
+686
| # Parse response for errors (successful uploads return 200 with no body) | ||
| if not (200 <= response.status_code < 300): |
There was a problem hiding this comment.
this comment doesn't seem to match the logic. We treat everything between 200 and 299 a success in the code. Could the API actually return something other than 200 for success?
There was a problem hiding this comment.
probably not! the docs only specify 200
chrisballinger
force-pushed
the
image-support
branch
from
8dc8128 to
2c90be4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds support for managing images: https://developer.apple.com/documentation/retentionmessaging/upload-image
also updates the cli README examples to be more contextually appropriate
upstream PR here: apple#159