Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jupyter_server to list of exceptions for keeping __doc__ strings #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add jupyter_server to list of exceptions for keeping __doc__ strings #34

wants to merge 1 commit into from

Conversation

jsharpe
Copy link
Contributor

@jsharpe jsharpe commented Feb 18, 2021

No description provided.

@jhance
Copy link
Contributor

jhance commented Oct 24, 2021

I think it would make more sense for this list to go in cfg.py, or disable this feature altogether in the open source version of our build tools

@jhance
Copy link
Contributor

jhance commented Oct 27, 2021

Actually, I think it makes sense to remove this list entirely, and add a flag to piplib preserve_docstrings that defaults False.

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsharpe @jhance @CLAassistant