Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated README.md to make the tutorial work #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zyxue
Copy link

@zyxue zyxue commented Feb 21, 2021

I find I need to make these edits to make the tutorial work.

for the i.encode('utf-8') part, if not specified, the error would've been

Traceback (most recent call last):
  File "wsgiref/handlers.py", line 138, in run
    self.finish_response()
  File "wsgiref/handlers.py", line 184, in finish_response
    self.write(data)
  File "wsgiref/handlers.py", line 279, in write
    assert type(data) is bytes, \
AssertionError: write() argument must be a bytes instance

@benjaminp
Copy link
Contributor

benjaminp commented Feb 22, 2021

Thanks. I think it would make the most sense to only support Python 3. So, add python2_compatible = False where necessary.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants