-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds queries to SDK manifest #509
Conversation
a2e990d
to
f48b9d2
Compare
Please be sure to fully test the auth flow with the official Dropbox Android app installed with this change. Also, make sure that nothing breaks in the case where the app already has the As long as that all works fine, let's take out the "Add Dropbox package to queries" section of the documentation along with this change. Thanks! |
Actually, small change to my previous comment; don't remove the documentation with this change itself. Remove the documentation once this change goes out in a release. |
06995a6
to
1187d00
Compare
@greg-db Ill be integrating with the snapshot before the 6.0.0 release goes out and and will make changes to the docs when bumping the snapshot version. |
I'm not sure we're set up with build level integration tests to be able to write automated tests for these cases, but I've manually tested these two cases using the example app to validate that they don't present an issue.
|
Adding the queries element to the SDK's manifest means that consumers don't need to.