Mark StoneTask as cacheable and resolve some dbapp integration issues #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdziemia
commented
Nov 30, 2023
Comment on lines
-5
to
-7
| alias(dropboxJavaSdkLibs.plugins.maven.publish.plugin) | ||
| alias(dropboxJavaSdkLibs.plugins.gradle.version.plugin) | ||
| alias(dropboxJavaSdkLibs.plugins.dependency.guard) |
There was a problem hiding this comment.
dbapp already has these on classpath so alias fails because each include a version and plugin block cannot handle this.
wdziemia
commented
Nov 30, 2023
Comment on lines
+31
to
+36
| String versionName | ||
| if (project.hasProperty("VERSION_NAME")) { | ||
| versionName = "${project.property("VERSION_NAME")}" | ||
| } else { | ||
| versionName = project.version | ||
| } |
There was a problem hiding this comment.
This project will use VERSION_NAME during publish, dbapp has no visibility on gradle.properties as it has its own. We use project.version as a fallback and set it within dbapp.
wdziemia
commented
Nov 30, 2023
| import org.gradle.process.ExecOperations | ||
| import java.io.File | ||
| import java.io.FileOutputStream | ||
| import javax.inject.Inject | ||
|
|
||
| @CacheableTask |
There was a problem hiding this comment.
With help of @devPalacio - marks this Task as cacheable which should increase build speeds
devPalacio
approved these changes
Nov 30, 2023
rharter
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.