-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend test matrix up to 3.12 #484
base: main
Are you sure you want to change the base?
Conversation
Thanks for putting this together! I'll ask the team to review this. |
Does this fail on 3.12 with #483? |
@@ -77,6 +77,10 @@ | |||
'Programming Language :: Python :: 3.6', | |||
'Programming Language :: Python :: 3.7', | |||
'Programming Language :: Python :: 3.8', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 36 in f40e73f
'pytest-runner == 5.2.0', |
I think something like 'setuptools; python_version>="3.12"'
should be added to the setup_requires
list.
Without this I can't create a virtual env for this library on Python 3.12
@hugovk It did not fail on 3.12 for the CI: https://github.com/foarsitter/dropbox-sdk-python/actions/runs/6707504248 |
@foarsitter this is because
I think the packages in the If you remove |
@sarahboyce do you think it is sufficient to not pin setuptools and let pip decide? Thanks for pointing out that sphinx was installing setuptools in this case. I added an issue to move to pyproject.toml: #487 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@foarsitter this is great! 🌟
Good idea to raise a separate issue around the setup, this PR achieves what we need 👍
In the same vein as #481, this PR updates the test matrix & classifiers up to the most recent 3.12.
Checklist
General Contributing
Is This a Code Change?
Validation
tox
pass?