Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package validation workflow. #144

Merged
merged 8 commits into from
Apr 18, 2024
Merged

Conversation

jewelpit
Copy link
Member

Summary

Having a job that regularly creates the packages and installs them using each distro's package manager is important for making sure we catch things like deprecated options and package renames as quickly as possible.

Test plan

The action running on this PR.

@goffrie
Copy link
Contributor

goffrie commented Apr 17, 2024

The workflow is not valid. .github/workflows/test_package_installation.yml (Line: 2, Col: 1): Unexpected value 'description'

@jewelpit
Copy link
Member Author

jewelpit commented Apr 17, 2024

I know, I'm fixing it :P

I also decided to just put it into the canary job, since splitting it up into the part that tests package installation on LTS versions (for use in validating changes in PRs) and the part that tests package installation on betas (to catch package renames) felt like more trouble than it was worth to avoid a tiny amount of GHA compute.

@jewelpit jewelpit merged commit 110998f into master Apr 18, 2024
11 checks passed
@jewelpit jewelpit deleted the package_install_validation branch April 18, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants