Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #157.
This PR implements a series of optimizations to try to reduce the amount of generated code with the aim of speeding up compilation. Altogether this makes our slowest proto crate a bit over 10% faster to compile (~41s to ~35s).
The changes, in separate commits, are:
into_known
for open enums into theOpenProtoEnum
trait, then use it to default-impl the other methods of that traitif let
instead offor
compute_grpc_slices_size
calls/impls for fields/types where we know statically that no Lazy<> fields are present. This uses the SCC analysis.