Skip to content

Commit

Permalink
Add explanation for objc route wrapper de-duplication
Browse files Browse the repository at this point in the history
  • Loading branch information
julianlocke committed Jan 5, 2024
1 parent 9cfc95f commit bb8a3d5
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions stone/backends/swift_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,10 @@ def _valid_route_for_auth_type(self, route):
else:
return not is_app_auth_only_route

Check warning on line 359 in stone/backends/swift_client.py

View check run for this annotation

Codecov / codecov/patch

stone/backends/swift_client.py#L359

Added line #L359 was not covered by tests

# The objc compatibility wrapper generates a class to wrap each route providing properly
# typed completion handlers without generics. User and App clients are generated in separate
# passes, and if the wrapper is already defined for the user client, we must skip generating
# a second definition of it for the app client.
def _objc_app_auth_route_wrapper_already_defined(self, route):
client_auth_type = self.args.auth_type
is_app_auth_client = client_auth_type == 'app'

Check warning on line 367 in stone/backends/swift_client.py

View check run for this annotation

Codecov / codecov/patch

stone/backends/swift_client.py#L365-L367

Added lines #L365 - L367 were not covered by tests
Expand Down

0 comments on commit bb8a3d5

Please sign in to comment.