Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix objc wrapper request box default inclusion #322

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

julianlocke
Copy link
Contributor

The logic here was incorrect and the correct logic is non-trivial as it requires knowledge of the specs from an unrelated run of stone (stone generates the Swift client and the SwiftObjc client in separate passes). Since an unneeded default is just an warning while a missing one is an error default to using a default, for now.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 103 lines in your changes are missing coverage. Please review.

Comparison is base (94fa542) 50.30% compared to head (9146372) 49.94%.
Report is 14 commits behind head on swifty-dropbox-beta.

Files Patch % Lines
stone/backends/swift_helpers.py 0.00% 34 Missing ⚠️
stone/backends/swift_client.py 0.00% 26 Missing ⚠️
stone/backends/swift_types.py 0.00% 25 Missing ⚠️
stone/cli.py 0.00% 16 Missing ⚠️
stone/backends/swift.py 0.00% 1 Missing ⚠️
stone/frontend/ir_generator.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           swifty-dropbox-beta     #322      +/-   ##
=======================================================
- Coverage                50.30%   49.94%   -0.37%     
=======================================================
  Files                       37       37              
  Lines                     8740     8803      +63     
  Branches                  1881     1888       +7     
=======================================================
  Hits                      4397     4397              
- Misses                    4026     4089      +63     
  Partials                   317      317              
Flag Coverage Δ
unit 49.94% <0.96%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julianlocke julianlocke merged commit be8bf9b into swifty-dropbox-beta Feb 14, 2024
11 of 12 checks passed
@julianlocke julianlocke deleted the fix-objc-wrapper-request-box-default branch February 14, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants