Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup feedback strings to use consistent quotes #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cleanup feedback strings to use consistent quotes #245

wants to merge 1 commit into from

Conversation

magicznyleszek
Copy link

Sorry for being quotes nazi, but it bothered me while I was preparing translations for zxcvbn.

Changes:

  1. Replaced unnecessary interpolations (double quotations) from few strings with literal ones (single).
  2. Replaced wrong in-text single quotations with proper ones.
  3. Had to escape ' in don\'ts because of changes.

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magicznyleszek
Copy link
Author

@lowe this is ready :) I just wonder, the last merged PR is from 5 years ago. Is this project still maintained by anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magicznyleszek @CLAassistant