Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deep_size_of_interned always returns a fixed value (close #51) #52

Merged
merged 7 commits into from
Jun 22, 2024
Merged

fix deep_size_of_interned always returns a fixed value (close #51) #52

merged 7 commits into from
Jun 22, 2024

Conversation

gmryuuko
Copy link
Contributor

@gmryuuko gmryuuko commented Jun 19, 2024 •
edited
Loading

fix #51
And fix a compile error when arena and deepsize are enabled at the same time.

@gmryuuko gmryuuko mentioned this pull request Jun 19, 2024
Closed
droundy
droundy approved these changes Jun 22, 2024
View reviewed changes
Copy link
Owner

@droundy droundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments where I think it might be approved, but assuming tests pass I'll probably just merge as is. Thanks so much for this careful and thoughtful contribution!

src/arena.rs Outdated Show resolved Hide resolved
src/intern.rs Outdated Show resolved Hide resolved
src/intern.rs Outdated Show resolved Hide resolved
@gmryuuko
Copy link
Contributor Author

I left a few comments where I think it might be approved, but assuming tests pass I'll probably just merge as is. Thanks so much for this careful and thoughtful contribution!

fixed

@droundy
Copy link
Owner

droundy commented Jun 22, 2024

I left a few comments where I think it might be approved, but assuming tests pass I'll probably just merge as is. Thanks so much for this careful and thoughtful contribution!

fixed

Wow, that was fast!

@droundy droundy merged commit 7ddb1c5 into droundy:master Jun 22, 2024
7 of 9 checks passed
@gmryuuko gmryuuko deleted the fix/deepsize branch June 22, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droundy droundy droundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The result of deep_size_of_interned is incorrect
2 participants
@gmryuuko @droundy