[gogenproto] Support for automatic go package mappings #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drshriveer
approved these changes
Jan 24, 2024
gogenproto/gen/generate.go
Outdated
| @@ -88,3 +124,18 @@ func (lw logPipe) Write(p []byte) (n int, err error) { | |||
| Logger.Println(toLog) | |||
| return len(p), nil | |||
| } | |||
|
|
|||
| func PackageNameFromPath(fileName string) (string, error) { | |||
There was a problem hiding this comment.
mind moving this to gogenproto? It seems pretty useful to have there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
→ When using
gogenprotoit is currently difficult to import protos from other packages, unless those protos specify the full absolute Go package ingo_package. I'd rather have this all be implicit in the directory structure.Changes
--go_opt=Mbetween that import path and the full Go package path that the file would be imported from. This means users no longer have to specifygo_packagein their protos at all, and can import protos from other paths via-includewithout having to do anything special to make the Go import paths work.OutputDiroption as it is annoying to work into this solution and it somewhat undermines the simplicity of "generate code next to these protos".Testing