Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds firmware content to documentation #48

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

darigovresearch
Copy link
Collaborator

Would resolve #41 if merged

Copy link
Owner

@drspangle drspangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The objects.inv file should really be generated in the human-readable format, otherwise we're version controlling a file which is just a binary blob, and that's a bit silly (plus it bloats the history). Apparently it's possible to generate this file, you just need to use intersphinx. I'm not sure how you've set this up so I can't remark further, but unless you're really sure we should be committing this file as-is I think we should try to fix this.

@darigovresearch
Copy link
Collaborator Author

@drspangle just followed the instructions written in pull request #47 which is just the default in the sphinx documentation.

Not sure what the .inv file is for, would you like it to be added to the .gitignore file?

Not sure what is intersphinx, can you provide links and what was the procedure that you used to build the docs?

@drspangle
Copy link
Owner

I think this is no longer necessary anymore.

@drspangle drspangle closed this Jul 10, 2021
@drspangle
Copy link
Owner

Oops, I mistook this for something else. I guess this is still useful, but it doesn't conform to the updated documentation anymore, so it might need reworking.

@drspangle drspangle reopened this Jul 10, 2021
@leonhma
Copy link
Contributor

leonhma commented Jul 11, 2021

i kinda did the same thing in #54

@darigovresearch
Copy link
Collaborator Author

@drspangle & @leonhma to better coordinate the docs can we decide what is the best way to move forward with the docs?

From our understanding (from #54) @leonhma will be made a maintainer in order to set the docs to be on read the docs & no longer using GitHub pages?

If so would probably be best to let @leonhma resolve the firmware docs via their pull request instead along with removing any source files for the GitHub pages

@leonhma
Copy link
Contributor

leonhma commented Jul 24, 2021

What i would do is Setup the Docs on rtd and also enable PR Preview builds. The source Files will still be kept in a folder in the GitHub repo. Sorry for the spelling/ and upper-/lowercase. Im kinda busy rn and autocorrect is very much Not helping (im German)

Edit: @drspangle i Just saw the invitation from 13 days ago. I didnt get a notification from the github app though. Maybe you could resend it?

@darigovresearch
Copy link
Collaborator Author

@leonhma no worries on the spelling & capitalisation. @drspangle could you resend the request to @leonhma (if you haven't already) so they can make the relevant updates so they can resolve the two open pull requests?

@darigovresearch darigovresearch added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 8, 2021
@drspangle
Copy link
Owner

@darigovresearch It looks like @leonhma has already accepted the invitation.

@darigovresearch
Copy link
Collaborator Author

@leonhma do you need anything else to resolve what is required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add firmware instructions to documentation
3 participants