queryType: select #13
Conversation
|
|
||
| :param str datasource: Data source to query | ||
| :param str granularity: Time bucket to aggregate data by hour, day, minute, etc. | ||
| :param dict pagingSpec: Indicates offsets into different scanned segments |
There was a problem hiding this comment.
paging_spec would be more pythonic for the kwarg
There was a problem hiding this comment.
Right, will do.
|
Looks good to me! Just left some minor comments. I can't merge tho. |
|
Hi @KenjiTakahashi, all Metamarkets open-source projects are covered by the same CLA as Druid. If you are contributing on behalf of an organization, please have your company fill out the corporate CLA and email it to us: https://github.com/metamx/druid/raw/master/DruidCorporateCLA.pdf If you are working on your own behalf and agree to the CLA, responding with a comment of "I agree to the terms of the Metamarkets Individual CLA as it exists in the current master branch" is sufficient: https://github.com/metamx/druid/raw/master/DruidIndividualCLA.pdf |
| @@ -7,3 +7,5 @@ build/ | |||
| dist/ | |||
| pyDruid.egg-info/ | |||
|
|
|||
| *~ | |||
There was a problem hiding this comment.
no need to add those to the project, you can add those to your global .gitignore
There was a problem hiding this comment.
Oh, I honestly did not know about that option. Well, you learn something every day :-).
KenjiTakahashi
force-pushed
the
new_query_types
branch
from
e01fd24 to
602cc04
Compare
|
@fjy I have just sent you the CLA. Sorry for the delay, had to reach our Sheriff on this :-). |
Since we plan to use it, I went away and implemented first piece for #11 myself :-).