Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null paths #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lazysoundsystem
Copy link

A sticking plaster for the error in #43

@jonpugh
Copy link

jonpugh commented Jun 27, 2023

Can we boost this fix?

The only way I can get composer install working on my project is to roll back composer to 2.5.5 or use this fork.

@JonathanH-UK
Copy link

I've hit this too.. +1 for merging the PR please

Copy link

@colinstillwell colinstillwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same problem for me, would love to see this come in and become part of a stable release version.

@sandykadam
Copy link

Please merge this and release this asap! PHP8 upgrade is stuck because of this error.

Copy link

@ivangrynenko ivangrynenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this PR and create an official release.
+1

@gargsuchi
Copy link

Please merge this PR and create an official release.
+1

@vladdancer
Copy link

Same thing for me. +1 for mergin PR.

@lisotton
Copy link

lisotton commented Sep 7, 2023

Same for me, +1 for merge this PR.

@mxr576
Copy link

mxr576 commented Mar 13, 2024

Null paths can be and probably should be handled at the source: \DrupalComposer\PreservePaths\PluginWrapper::getInstallPathsFromPackages()

diff --git a/src/PluginWrapper.php b/src/PluginWrapper.php
--- a/src/PluginWrapper.php	
+++ b/src/PluginWrapper.php	(date 1710258587092)
@@ -136,6 +136,8 @@
             $paths[] = $installationManager->getInstallPath($package);
         }
 
+        $paths = array_filter($paths);
+
         return $this->absolutePaths($paths);
     }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.