Skip to content

Commit

Permalink
Moving module changes into eventSubscriber.
Browse files Browse the repository at this point in the history
  • Loading branch information
apathak18 committed Aug 2, 2024
1 parent 27327f6 commit e74a854
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
jobs:
drupal:
name: Drupal ${{ matrix.drupal-core }} (PHP ${{ matrix.php-versions }})
# We cannot use ubuntu-latest right now as it still points to 22.04 and we need a newer database driver."
# We cannot use ubuntu-latest right now as it still points to 22.04 and we need a newer database driver.
runs-on: ubuntu-24.04
env:
extensions: mbstring, xml, pdo_sqlite, gd, opcache
Expand Down
17 changes: 0 additions & 17 deletions tests/modules/graphql_file_validate/graphql_file_validate.module

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ class GraphqlFileValidationTestSubscriber implements EventSubscriberInterface {
* The event.
*/
public function onFileValidation(FileValidationEvent $event): void {
graphql_file_validate_test_file($event->file);
if (!file_exists($event->file->getFileUri())) {
throw new \Exception('File does not exist during validation: ' . $file->getFileUri());

Check failure on line 23 in tests/modules/graphql_file_validate/src/EventSubscriber/GraphqlFileValidationTestSubscriber.php

View workflow job for this annotation

GitHub Actions / Drupal 11.0.x (PHP 8.3)

Undefined variable: $file
}
}

/**
Expand Down

0 comments on commit e74a854

Please sign in to comment.