Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added directives to extensions #1216

Open
wants to merge 6 commits into
base: 8.x-4.x
Choose a base branch
from

Conversation

blazeyo
Copy link
Contributor

@blazeyo blazeyo commented Jun 30, 2021

No description provided.

Copy link
Contributor

@klausi klausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I fully understand what you are trying to accomplish here, but looks interesting.

Can you update the description here with a use case?

namespace Drupal\Tests\graphql\Kernel;

/**
* Test the entity_definition data producer and friends.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong comment?

@klausi klausi added the 4.x label Jul 3, 2021
/**
* {@inheritdoc}
*/
protected $strictConfigSchema = FALSE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why we disable that? Please add a code comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants