Recognize more pass-through constructor signatures #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash-gordon
force-pushed
the
recognize-more-pass-through-signatures
branch
5 times, most recently
from
f1df138 to
e2a22f6
Compare
flash-gordon
force-pushed
the
recognize-more-pass-through-signatures
branch
from
e2a22f6 to
9ecab4c
Compare
flash-gordon
changed the title
|
At first, I hoped it'd fix #91 but now I think it can't be fixed generally. Generalizing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, ruby introduced more ways to express method parameters that you're not going to use explicitly. We should have updated our
pass_through?check accordingly.