Make DidYouMean integration optional
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gem won't load when DidYouMean is disabled with --disable-did_you_mean: ``` RUBYOPT='--disable-did_you_mean' rake [...] NameError: uninitialized constant Dry::Container::DidYouMean # ./lib/dry/container/error.rb:9:in `<class:Container>' ``` With this commit, the gem loads even though some tests fail.
|
Ah, sorry about that. I wrote the PR that added this feature and I failed to consider |
solnic
approved these changes
Jul 29, 2022
|
Thanks for the PR. I just released 0.10.1 with your fix. |
|
Thanks a ton @solnic 🙇. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gem won't load when DidYouMean is disabled with
--disable-did_you_mean:
With this commit, the gem loads even though some tests fail.
We run some of our Ruby apps with
--disable-did_you_meanfor performance reasons, hence the change.I didn't write any tests for this. The only test I could think of would be something like shelling out to load a new Ruby interpreter without
DidYouMeanand validating that it doesn't fail:I didn't see a lot of value in such test, but open to feedback or alternative.