Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a compatibility issue with active_support Object#with monkey patching #90

Closed
wants to merge 1 commit into from

Conversation

tallica
Copy link

@tallica tallica commented Feb 22, 2024

Fixes a compatibility issue with ActiveSupport monkey patching Object#with: https://github.com/rails/rails/blob/v7.1.3/activesupport/lib/active_support/core_ext/object/with.rb

Example error:

NoMethodError:
  undefined method `payload=' for #<Dry::Effects::Effect type=:resolve name=:resolve payload=[] keywords={}>

@Tyflomate
Copy link

Same issue here ! Thanks for the temp patch !

Copy link

@Tao-Galasse Tao-Galasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ran into the same issue recently and this is exactly what we needed :)

Thanks for you fix @tallica ! 😊

Hey @flash-gordon, do you think this could be merged & released on rubygems ? 🙏

@flash-gordon
Copy link
Member

Sorry for the delay, I made a fix in the main branch, and I'll give it a try in one project of mine where I'm fortunate to have activesupport in dependencies. Once the checks are complete, I'll release a new version. Thank you for heads-up

@flash-gordon
Copy link
Member

0.4.1 is out, it works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants