Skip to content

Commit

Permalink
Fix review comments at r1
Browse files Browse the repository at this point in the history
  • Loading branch information
johlju committed Jul 11, 2019
1 parent 8ae34f1 commit 8d85283
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
[ClassVersion("1.0.1.0"), FriendlyName("xADDomainTrust")]
class MSFT_xADDomainTrust : OMI_BaseResource
{
[Write, Description("Specifies whether the computer account is present or absent. Valid values are 'Present' and 'Absent'. The default is 'Present'."), ValueMap{"Present","Absent"}, Values{"Present","Absent"}] String Ensure;
[Write, Description("Specifies whether the computer account is present or absent. Default value is 'Present'."), ValueMap{"Present","Absent"}, Values{"Present","Absent"}] String Ensure;
[Required, Description("Specifies the credentials to authenticate to the target domain."), EmbeddedInstance("MSFT_Credential")] String TargetDomainAdministratorCredential;
[Key, Description("Specifies the name of the Active Directory domain that is being trusted.")] String TargetDomainName;
[Required, Description("Specifies the type of trust. Valid values are 'External' or 'Forest'. 'External' means the context Domain, while 'Forest' means the context 'Forest'."), ValueMap{"External","Forest"}, Values{"External","Forest"}] String TrustType;
[Required, Description("Specifies the direction of the trust. Valid values are 'Bidirectional', 'Inbound', and 'Outbound'."), ValueMap{"Bidirectional","Inbound","Outbound"}, Values{"Bidirectional","Inbound","Outbound"}] String TrustDirection;
[Required, Description("Specifies the type of trust. The value 'External' means the context Domain, while the value 'Forest' means the context 'Forest'."), ValueMap{"External","Forest"}, Values{"External","Forest"}] String TrustType;
[Required, Description("Specifies the direction of the trust."), ValueMap{"Bidirectional","Inbound","Outbound"}, Values{"Bidirectional","Inbound","Outbound"}] String TrustDirection;
[Key, Description("Specifies the name of the Active Directory domain that is requesting the trust.")] String SourceDomainName;
};
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
xADDomainTrust

.DESCRIPTION
The xADDomainTrust DSC resource will manage Domain Trusts within Active Directory. A trust is a relationship, which you establish between domains, that makes it possible for users in one domain to be authenticated by a domain controller in the other domain.
The xADDomainTrust DSC resource will manage Domain Trusts within Active Directory. A trust is a relationship, which you establish between domains or forests. That makes it possible for users in one domain to be authenticated by a domain controller in the other domain.

## Requirements

Expand All @@ -11,7 +11,7 @@
.PARAMETER Ensure
Write - String
Allowed values: Present, Absent
Specifies whether the computer account is present or absent. Valid values are 'Present' and 'Absent'. The default is 'Present'.
Specifies whether the computer account is present or absent. Default value is 'Present'.

.PARAMETER TargetDomainAdministratorCredential
Required - String
Expand All @@ -24,12 +24,12 @@
.PARAMETER TrustType
Required - String
Allowed values: External, Forest
Specifies the type of trust. Valid values are 'External' or 'Forest'. 'External' means the context Domain, while 'Forest' means the context 'Forest'.
Specifies the type of trust. The value 'External' means the context Domain, while the value 'Forest' means the context 'Forest'.

.PARAMETER TrustDirection
Required - String
Allowed values: Bidirectional, Inbound, Outbound
Specifies the direction of the trust. Valid values are 'Bidirectional', 'Inbound', and 'Outbound'.
Specifies the direction of the trust.

.PARAMETER SourceDomainName
Key - String
Expand Down

0 comments on commit 8d85283

Please sign in to comment.