xADDomainTrust: Refactor resource and add tests (#423)

- Changes to xActiveDirectory
  - Added new helper functions in xActiveDirectory.Common.
    - New-CimCredentialInstance
    - Add-TypeAssembly
    - New-ADDirectoryContext
- Changes to xADDomainTrust
  - Refactored the resource to enable unit tests, and at the same time changed
    it to use the same code pattern as the resource xADObjectEnabledState.
  - Added unit tests (issue #324).
  - Added comment-based help (issue #337).
  - Added integration tests (issue #348).

CHANGELOG.md

@@ -29,6 +29,10 @@
   - The default value on resource parameters are now reflected in the parameter
     descriptions in the schema.mof (so that Wiki will be updated)
     ([issue #426](https://github.com/PowerShell/xActiveDirectory/issues/426)).
+  - Added new helper functions in xActiveDirectory.Common.
+    - New-CimCredentialInstance
+    - Add-TypeAssembly
+    - New-ADDirectoryContext
 - Changes to xADManagedServiceAccount
   - Added a requirement to README stating "Group Managed Service Accounts
     need at least one Windows Server 2012 Domain Controller"
@@ -54,6 +58,12 @@
 - Changes to xADServicePrincipalName
   - Minor change to the unit tests that did not correct assert the localized
     string when an account is not found.
+- Changes to xADDomainTrust
+  - Refactored the resource to enable unit tests, and at the same time changed
+    it to use the same code pattern as the resource xADObjectEnabledState.
+  - Added unit tests ([issue #324](https://github.com/PowerShell/xActiveDirectory/issues/324)).
+  - Added comment-based help ([issue #337](https://github.com/PowerShell/xActiveDirectory/issues/337)).
+  - Added integration tests ([issue #348](https://github.com/PowerShell/xActiveDirectory/issues/348)).
 
 ## 3.0.0.0
 

DSCResources/MSFT_xADComputer/en-US/about_xADComputer.help.txt

@@ -6,17 +6,17 @@
     This resource can be used to provision a computer account before the computer is
     added to the domain. These pre-created computer objects can be used with offline
     domain join, unsecure domain Join and RODC domain join scenarios.
-    
+
     >**Note:** An Offline Domain Join (ODJ) request file will only be created
     >when a computer account is first created in the domain. Setting an Offline
     >Domain Join (ODJ) Request file path for a configuration that updates a
     >computer account that already exists, or restore it from the recycle bin
     >will not cause the Offline Domain Join (ODJ) request file to be created.
-    
+
     ## Requirements
-    
+
     * Target machine must be running Windows Server 2008 R2 or later.
-    
+
 .PARAMETER ComputerName
     Key - String
     Specifies the name of the Active Directory computer account to manage. You can identify a computer by its distinguished name, GUID, security identifier (SID) or Security Accounts Manager (SAM) account name.

DSCResources/MSFT_xADDomain/en-US/about_xADDomain.help.txt

@@ -3,11 +3,11 @@
 
 .DESCRIPTION
     The xADDomain resource creates a new domain in a new forest or a child domain in an existing forest. While it is possible to set the forest functional level and the domain functional level during deployment with this resource the common restrictions apply. For more information see [TechNet](https://docs.microsoft.com/en-us/windows-server/identity/ad-ds/active-directory-functional-levels).
-    
+
     ## Requirements
-    
+
     * Target machine must be running Windows Server 2008 R2 or later.
-    
+
 .PARAMETER DomainName
     Key - String
     The fully qualified domain name (FQDN) of the new domain.

DSCResources/MSFT_xADDomainController/en-US/about_xADDomainController.help.txt

@@ -4,19 +4,19 @@
 .DESCRIPTION
     The xADDomainController DSC resource will install and configure domain
     controllers in Active Directory.
-    
+
     >**Note:** If the account used for the parameter `DomainAdministratorCredential`
     >cannot connect to another domain controller, for example using a credential
     >without the domain name, then the cmdlet `Install-ADDSDomainController` will
     >seemingly halt (without reporting an error) when trying to replicate
     >information from another domain controller.
     >Make sure to use a correct domain account with the correct permission as
     >the account for the parameter `DomainAdministratorCredential`.
-    
+
     ## Requirements
-    
+
     * Target machine must be running Windows Server 2008 R2 or later.
-    
+
 .PARAMETER DomainName
     Key - String
     The fully qualified domain name (FQDN) of the domain the Domain Controller will be joining.

DSCResources/MSFT_xADDomainDefaultPasswordPolicy/en-US/about_xADDomainDefaultPasswordPolicy.help.txt

@@ -3,11 +3,11 @@
 
 .DESCRIPTION
     The xADDomainDefaultPasswordPolicy DSC resource will manage an Active Directory domain's default password policy.
-    
+
     ## Requirements
-    
+
     * Target machine must be running Windows Server 2008 R2 or later.
-    
+
 .PARAMETER DomainName
     Key - String
     Name of the domain to which the password policy will be applied.