Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke-Git: Fix new line in returned strings #94

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 8, 2021

Pull Request

Pull Request (PR) description

  • Invoke-Git
    • No longer write a new line to the end of string for the returned properties
      StandardOutput and StandardError.

This Pull Request (PR) fixes the following issues

Possibly #84

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • Integration tests added/updated (where possible).
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #94 (d8de6b2) into main (df9cf25) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@        Coverage Diff         @@
##           main   #94   +/-   ##
==================================
  Coverage    97%   97%           
==================================
  Files        38    38           
  Lines       893   895    +2     
==================================
+ Hits        875   877    +2     
  Misses       18    18           

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit dd65819 into dsccommunity:main Jul 8, 2021
@johlju johlju deleted the fix/invoke-git-strings branch July 8, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant