X exch autodiscover virtual directory

[arielmoisis]

Pull Request (PR) description

Update Test-TargetResource Unit tests in MSFT_xExchAutodiscoverVirtualDirectory.tests.ps1 that have a reference to Get-UMCallRouterSettings to Get-AutodiscoverVirtualDirectory

This Pull Request (PR) fixes the following issues

If this PR does not fix an open issue, replace this comment block with None.
If this PR resolves one or more open issues, replace this comment block with
a list the issues using a GitHub closing keyword, e.g.:
- Fixes #403 

Task list

• Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

[codecov]

Codecov Report

Merging #436 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #436   +/-   ##
=======================================
  Coverage   48.09%   48.09%           
=======================================
  Files          44       44           
  Lines        5603     5603           
=======================================
  Hits         2695     2695           
  Misses       2908     2908

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7173e9f...25e1994. Read the comment docs.

[mhendric]

Hey @gaelcolas and @johlju , am I crazy, or is this PR missing the reviewable.io link (or both!)? And if this is missing, is this intentional? Thanks.

[mhendric]

@gaelcolas , I have three PR's in xExchange since the transferring of repos that are stuck on license/cla check, and which don't show the reviewable.io link. Can you let me know what needs to be done here? The other two problem PR's are #437 and #438.

[mhendric]

Sorry for the wait on this @arielmoisis . Not sure who to talk to for help with getting the reviewable button to show, and getting the license/cla to clear. I'm going to go ahead and merge this anyways, as the code change is simple enough and looks good to me. Tagging a couple more folks, @PlagueHO and @SSvilen , in case they have any idea of how to solve this for other PR's in this repo.

[SSvilen]

Hi @mhendric ,

I think the CLA bot can not get the required information. I get the CLA displayed for https://cla.opensource.microsoft.com/PowerShell/ but not for dsccommunity. I can try to revoke the access for the CLA app before my next PR and see if that brings anything.

[johlju]

There are no need for the CLA any longer since the repo are now part of the DSC Community. @mhendric you should have permission to remove that status check, if not let me know. See branch protection rules here https://github.com/dsccommunity/xExchange/settings/branches

Reviewable needed to be reconnected, I did that now, but it was as easy as look at the URL on a previous PR (https://reviewable.io/reviews/dsccommunity/xexchange/431) and browse to another Pr like https://reviewable.io/reviews/dsccommunity/xexchange/439 and then when the review was shown, reviewable detected that the repo had been moved and asked if it should connected again. So, Reviewable should work again. I make a note of this in the conversion steps.

[mhendric]

You rock, @johlju . Thanks!