Skip to content

Commit

Permalink
SqlServerDsc: Deprecating SqlServerNetwork (#1544)
Browse files Browse the repository at this point in the history
  • Loading branch information
johlju authored May 12, 2020
1 parent 23e2a8f commit 10233fe
Show file tree
Hide file tree
Showing 7 changed files with 449 additions and 4 deletions.
12 changes: 8 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Removed
### Deprecated

- SqlServerDsc
- BREAKING CHANGE: Removed resource _SqlServerNetwork_. The functionality
is now covered by the resources _SqlServerProtocol_ and _SqlServerProtocolTcpIp_.
The documentation, examples, unit test, and integration tests have been
removed for these deprecated resources.

- SqlServerNetwork
- This resource is now deprecated. The functionality is now covered by
the resources _SqlServerProtocol_ and _SqlServerProtocolTcpIp_.

### Added

Expand Down Expand Up @@ -38,6 +41,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- SqlServerDsc
- Changed all resource prefixes from `MSFT_` to `DSC_` ([issue #1496](https://github.com/dsccommunity/SqlServerDsc/issues/1496)).
_Deprecated resource has not changed prefix._
- All resources are now using the common module DscResource.Common.
- When a PR is labelled with 'ready for merge' it is no longer being
marked as stale if the PR is not merged for 30 days (for example it is
Expand Down
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,14 @@ for some general use scenarios for all of the resources that are in the module.

A full list of changes in each version can be found in the [change log](CHANGELOG.md).

### Deprecated resources

The documentation, examples, unit test, and integration tests have been removed
for these deprecated resources.

* SqlServerNetwork _(replaced by [**SqlServerProtocol**](#sqlserverprotocol) and_
_[**SqlServerProtocolTcpIp**](#sqlserverprotocoltcpip))_.

## Resources

* [**SqlAG**](#sqlag)
Expand Down
6 changes: 6 additions & 0 deletions build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ Pester:
OutputFormat: NUnitXML
ExcludeFromCodeCoverage:
- Modules/DscResource.Common
# Deprecated resources
- source/DSCResources/MSFT_SqlServerNetwork
Script:
- tests/Unit
ExcludeTag:
Expand All @@ -73,8 +75,12 @@ DscTest:
Tag:
ExcludeSourceFile:
- output
# Deprecated resources
- source/DSCResources/MSFT_SqlServerNetwork
ExcludeModuleFile:
- Modules/DscResource.Common
# Deprecated resources
- DSCResources/MSFT_SqlServerNetwork

Resolve-Dependency:
Gallery: 'PSGallery'
Expand Down
4 changes: 4 additions & 0 deletions codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,7 @@ coverage:

fixes:
- '\d+\.\d+\.\d+\/::source/' # move path "X.Y.Z/" => "source/"

# Deprecated resources
ignore:
- 'source/DSCResources/MSFT_SqlServerNetwork'
Loading

0 comments on commit 10233fe

Please sign in to comment.