-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: ReverseDSC Native Support #1434
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1434 +/- ##
=====================================
- Coverage 98% 90% -8%
=====================================
Files 38 39 +1
Lines 5603 6026 +423
=====================================
- Hits 5497 5444 -53
- Misses 106 582 +476 |
Will work on adding Unit Tests later today |
Trying to see how test engine works, since this is my first commit to this repo.
@johlju wait before review. Trying to familiarize myself with the Unit Tests setup so I might submit a few extra commits. You can have a look at the general structure of the PR though to get an idea of what's coming your way :) |
Hey @NikCharlebois, that's a huge effort you put in, but I wouldn't be too happy putting that much code in the DSC resources, even more that the feature is not (some could argue 'yet') part of the DSC technology. |
There are a lot of duplicated code introduced with this change, I also want to look over this to see that it actually the correct way of doing this. Please continue resolving comments on this change, but I will add an 'on hold' label for the time-being so we have chance to discuss this. I have offline conversation with @NikCharlebois about this, but I have not have time to get back to that yet. |
The new CI pipeline has merged. This changed the folder structure, and also removed the dev branch. Please rebase against the master branch, and make sure to get your changes into the the file in the new location (under Read more here about the new coding workflow: |
Hello @NikCharlebois, I see this is the same approach used in Microsoft365Dsc too. In the early days of ReverseDSC this was done as an external "orchestrator" module, such as https://github.com/Microsoft/SQLServerDSC.Reverse, but I see that hasn't been so active recently, did you run into a problem with this approach? |
Pull Request (PR) description
This PR introduces native ReverseDSC support for SQLServerDSC. It exposes a new Export-SQLServerConfiguration cmdlet that Reverse Engineers existing SQL Server environment and generates a resulting DSC script that is a full-fidelity representation of the existing settings on the server.
This Pull Request (PR) fixes the following issues
N/A
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is