Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Bump PSResourceGet to v1.0.0 #1975

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Oct 10, 2023

Pull Request (PR) description

  • SqlServerDsc
    • Bump PSResourceGet to v1.0.0 (used when resolving dependencies).

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1975 (b04d15c) into main (350c705) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1975   +/-   ##
====================================
  Coverage    92%     92%           
====================================
  Files        93      93           
  Lines      7840    7840           
====================================
  Hits       7214    7214           
  Misses      626     626           
Flag Coverage Δ
unit 92% <ø> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit e0bf6a5 into dsccommunity:main Oct 13, 2023
34 checks passed
@johlju johlju deleted the fix/bump-psresourceget branch October 13, 2023 04:58
@johlju johlju removed the needs review The pull request needs a code review. label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant