Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlDatabasePermission: Fix Credential property #1984

Conversation

johlju
Copy link
Member

@johlju johlju commented Dec 6, 2023

Pull Request (PR) description

  • SqlDatabasePermission
    • Now correctly return the username in the property Credential.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #1984 (9d65897) into main (e9639fd) will decrease coverage by 2%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           main   #1984     +/-   ##
======================================
- Coverage    92%     90%     -2%     
======================================
  Files        93      36     -57     
  Lines      7840    6312   -1528     
======================================
- Hits       7214    5718   -1496     
+ Misses      626     594     -32     
Flag Coverage Δ
unit 90% <ø> (-2%) ⬇️

see 57 files with indirect coverage changes

@johlju
Copy link
Member Author

johlju commented Dec 6, 2023

This won't work as the resource property Credential is not of the type CIM instance. So this is not the solution. Closing this.

@johlju johlju closed this Dec 6, 2023
@johlju johlju added the closed by author The issue or pull request was closed by the author. label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed by author The issue or pull request was closed by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlDatabasePermission: Return the correct username from Get-method for the Credential property
1 participant