Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localization hqrm #2050

Merged
merged 6 commits into from
Oct 26, 2024
Merged

Conversation

johlju
Copy link
Member

@johlju johlju commented Oct 20, 2024

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (5677cd5) to head (b0d72ef).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #2050   +/-   ##
====================================
  Coverage    94%     94%           
====================================
  Files        94      94           
  Lines      7930    7930           
====================================
  Hits       7500    7500           
  Misses      430     430           
Flag Coverage Δ
unit 94% <ø> (ø)
Files with missing lines Coverage Δ
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1 96% <ø> (ø)

@johlju johlju marked this pull request as ready for review October 21, 2024 18:02
@johlju johlju requested a review from a team as a code owner October 21, 2024 18:02
@johlju
Copy link
Member Author

johlju commented Oct 21, 2024

The issue dsccommunity/DscResource.DocGenerator#160 should be fixed before merging this.

@johlju johlju added on hold The issue or pull request has been put on hold by a maintainer. and removed on hold The issue or pull request has been put on hold by a maintainer. labels Oct 22, 2024
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 1bf09ec into dsccommunity:main Oct 26, 2024
44 checks passed
@johlju johlju deleted the fix/localization-hqrm-test branch October 26, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant