Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor version upgrade #2054

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

fix ScriptAnalyzer compliance

7ab71b2
Select commit
Loading
Failed to load commit list.
Draft

Minor version upgrade #2054

fix ScriptAnalyzer compliance
7ab71b2
Select commit
Loading
Failed to load commit list.
Azure Pipelines / dsccommunity.SqlServerDsc failed Dec 22, 2024 in 6h 31m 20s

Build #17.1.0-PR2054.16 had test failures

702 errors / 2 warnings

Details

Tests

  • Failed: 146 (1.51%)
  • Passed: 9,396 (97.25%)
  • Other: 120 (1.24%)
  • Total: 9,662
Code coverage

  • 36 of 37 class covered (97.30%)
  • 8218 of 8845 instruction covered (92.91%)
  • 7479 of 7973 line covered (93.80%)
  • 291 of 320 method covered (90.94%)

Annotations

Check failure on line 112 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dsccommunity.SqlServerDsc

Build log #L112 

   [-] Should have a unit test for Find-SqlDscLatestCu 97ms (94ms|3ms)

Check failure on line 125 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dsccommunity.SqlServerDsc

Build log #L125 

   [-] Should have a unit test for Get-SqlDscServerVersion 14ms (13ms|2ms)

Check failure on line 151 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dsccommunity.SqlServerDsc

Build log #L151 

   [-] Should have a unit test for Update-SqlDscServer 10ms (9ms|1ms)

Check failure on line 183 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dsccommunity.SqlServerDsc

Build log #L183 

   [-] Should pass Script Analyzer for Get-SqlDscServerVersion 114ms (113ms|1ms)

Check failure on line 1 in DSC_SqlSetup_Integration.When using configuration DSC_SqlSetup_InstallDatabaseEngineNamedInstanceAsSystem_Config.Should compile and apply the MOF without throwing

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dsccommunity.SqlServerDsc

DSC_SqlSetup_Integration.When using configuration DSC_SqlSetup_InstallDatabaseEngineNamedInstanceAsSystem_Config.Should compile and apply the MOF without throwing 

Expected no exception to be thrown, but an exception "Cannot find path 'HKLM:\SOFTWARE\Microsoft\Microsoft SQL Server\Instance Names\SQL' because it does not exist." was thrown from D:\a\1\s\tests\Integration\Resources\DSC_SqlSetup.Integration.Tests.ps1:297 char:17
    + ...               Start-DscConfiguration @startDscConfigurationParameters
    +                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~.
Raw output 
at } | Should -Not -Throw, D:\a\1\s\tests\Integration\Resources\DSC_SqlSetup.Integration.Tests.ps1:298
at Invoke-Assertion, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:11391
at Should<End>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:11334
at <ScriptBlock>, D:\a\1\s\tests\Integration\Resources\DSC_SqlSetup.Integration.Tests.ps1:279
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2206
at Invoke-TestItem, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1254
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:890
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1737
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.ps1:3
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:3150
at Invoke-InNewScriptScope, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:3157
at Run-Test, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1740
at Invoke-Test, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2554
at Invoke-Pester<End>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:5050
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Sampler\0.118.1\tasks\Invoke-Pester.pester.build.ps1:906
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:636
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:608
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:608
at <ScriptBlock><End>, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:794
at <ScriptBlock><Begin>, D:\a\1\s\build.ps1:532
at <ScriptBlock>, D:\a\_temp\64414ad3-fc30-42fc-a883-ed06fc938607.ps1:11
at <ScriptBlock>, <No file>:1

Check failure on line 1 in DSC_SqlSetup_Integration.When using configuration DSC_SqlSetup_InstallDatabaseEngineNamedInstanceAsSystem_Config.Should have set the resource and all the parameters should match

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dsccommunity.SqlServerDsc

DSC_SqlSetup_Integration.When using configuration DSC_SqlSetup_InstallDatabaseEngineNamedInstanceAsSystem_Config.Should have set the resource and all the parameters should match 

Expected '.\svc-SqlAgentPri', but got $null.
Raw output 
at $resourceCurrentState.AgtSvcAccountUsername      | Should -Be ('.\{0}' -f (Split-Path -Path $ConfigurationData.AllNodes.SqlAgentServicePrimaryAccountUserName -Leaf)), D:\a\1\s\tests\Integration\Resources\DSC_SqlSetup.Integration.Tests.ps1:315
at Invoke-Assertion, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:11391
at Should<End>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:11330
at <ScriptBlock>, D:\a\1\s\tests\Integration\Resources\DSC_SqlSetup.Integration.Tests.ps1:315
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2206
at Invoke-TestItem, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1254
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:890
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1737
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.ps1:3
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:3150
at Invoke-InNewScriptScope, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:3157
at Run-Test, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1740
at Invoke-Test, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2554
at Invoke-Pester<End>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:5050
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Sampler\0.118.1\tasks\Invoke-Pester.pester.build.ps1:906
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:636
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:608
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:608
at <ScriptBlock><End>, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:794
at <ScriptBlock><Begin>, D:\a\1\s\build.ps1:532
at <ScriptBlock>, D:\a\_temp\64414ad3-fc30-42fc-a883-ed06fc938607.ps1:11
at <ScriptBlock>, <No file>:1

Check failure on line 1 in DSC_SqlSetup_Integration.When using configuration DSC_SqlSetup_InstallDatabaseEngineNamedInstanceAsSystem_Config.Should return $true when Test-DscConfiguration is run

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dsccommunity.SqlServerDsc

DSC_SqlSetup_Integration.When using configuration DSC_SqlSetup_InstallDatabaseEngineNamedInstanceAsSystem_Config.Should return $true when Test-DscConfiguration is run 

Expected strings to be the same, but they were different.
Expected length: 4
Actual length:   5
Strings differ at index 0.
Expected: 'True'
But was:  'False'
           ^
Raw output 
at Test-DscConfiguration -Verbose | Should -Be 'True', D:\a\1\s\tests\Integration\Resources\DSC_SqlSetup.Integration.Tests.ps1:383
at Invoke-Assertion, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:11391
at Should<End>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:11330
at <ScriptBlock>, D:\a\1\s\tests\Integration\Resources\DSC_SqlSetup.Integration.Tests.ps1:383
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2206
at Invoke-TestItem, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1254
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:890
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1737
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.ps1:3
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:3150
at Invoke-InNewScriptScope, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:3157
at Run-Test, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1740
at Invoke-Test, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2554
at Invoke-Pester<End>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:5050
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Sampler\0.118.1\tasks\Invoke-Pester.pester.build.ps1:906
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:636
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:608
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:608
at <ScriptBlock><End>, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:794
at <ScriptBlock><Begin>, D:\a\1\s\build.ps1:532
at <ScriptBlock>, D:\a\_temp\64414ad3-fc30-42fc-a883-ed06fc938607.ps1:11
at <ScriptBlock>, <No file>:1

Check failure on line 1 in DSC_SqlSetup_Integration.When using configuration DSC_SqlSetup_StopServicesInstance_Config.Should compile and apply the MOF without throwing

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dsccommunity.SqlServerDsc

DSC_SqlSetup_Integration.When using configuration DSC_SqlSetup_StopServicesInstance_Config.Should compile and apply the MOF without throwing 

Expected no exception to be thrown, but an exception "PowerShell DSC resource DSC_xServiceResource  failed to execute Set-TargetResource functionality with error message: The service 'SQLAGENT$DSCSQLTEST' does not exist, but Path was not specified. Please specify the path to the executable the service should run to create a new service.
Parameter name: Path " was thrown from D:\a\1\s\tests\Integration\Resources\DSC_SqlSetup.Integration.Tests.ps1:417 char:17
    + ...               Start-DscConfiguration @startDscConfigurationParameters
    +                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~.
Raw output 
at } | Should -Not -Throw, D:\a\1\s\tests\Integration\Resources\DSC_SqlSetup.Integration.Tests.ps1:418
at Invoke-Assertion, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:11391
at Should<End>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:11334
at <ScriptBlock>, D:\a\1\s\tests\Integration\Resources\DSC_SqlSetup.Integration.Tests.ps1:399
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2206
at Invoke-TestItem, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1254
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:890
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1737
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.ps1:3
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:3150
at Invoke-InNewScriptScope, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:3157
at Run-Test, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1740
at Invoke-Test, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2554
at Invoke-Pester<End>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:5050
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Sampler\0.118.1\tasks\Invoke-Pester.pester.build.ps1:906
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:636
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:608
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:608
at <ScriptBlock><End>, D:\a\1\s\output\RequiredModules\InvokeBuild\5.12.1\Invoke-Build.ps1:794
at <ScriptBlock><Begin>, D:\a\1\s\build.ps1:532
at <ScriptBlock>, D:\a\_temp\64414ad3-fc30-42fc-a883-ed06fc938607.ps1:11
at <ScriptBlock>, <No file>:1
View more details on Azure Pipelines