-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoke-ReportServerSetupAction
: Add private command
#2066
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2066 +/- ##
====================================
Coverage 94% 94%
====================================
Files 94 95 +1
Lines 7926 7993 +67
====================================
+ Hits 7500 7566 +66
- Misses 426 427 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 8 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @johlju)
tests/Unit/Public/Install-SqlDscServer.Tests.ps1
line 656 at r2 (raw file):
} Context 'When specifying sensitive parameter <MockParameterName>' -ForEach @(
This test should be removed here because it testing Invoke-SetupAction
which is already tests in its own tests. But can be fixed in a separate PR.
Code quote:
Context 'When specifying sensitive parameter <MockParameterName>' -ForEach @(
tests/Unit/Public/Install-SqlDscServer.Tests.ps1
line 2284 at r2 (raw file):
} Context 'When specifying sensitive parameter <MockParameterName>' -ForEach @(
This test should be removed here because it testing Invoke-SetupAction
which is already tests in its own tests. But can be fixed in a separate PR.
Code quote:
Context 'When specifying sensitive parameter <MockParameterName>' -ForEach @(
Pull Request (PR) description
Invoke-ReportServerSetupAction
Save-SqlDscSqlServerMediaFile
Install-SqlDscServer
and private functionInvoke-SetupAction
This Pull Request (PR) fixes the following issues
Ground work fo issue #2010.
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is