Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke-ReportServerSetupAction: Add private command #2066

Merged
merged 7 commits into from
Mar 2, 2025

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 1, 2025

Pull Request (PR) description

  • Private function:
    • Invoke-ReportServerSetupAction
  • Save-SqlDscSqlServerMediaFile
    • Fix unit tests so the work cross-platform.
  • Install-SqlDscServer and private function Invoke-SetupAction
    • Fix localization string keys naming.
    • Fix unit tests to use correct localization string names.

This Pull Request (PR) fixes the following issues

Ground work fo issue #2010.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from a team as a code owner March 1, 2025 19:31
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 93.50649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94%. Comparing base (666ef4e) to head (9661dbd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
source/Private/Invoke-ReportServerSetupAction.ps1 95% 3 Missing ⚠️
source/Private/Invoke-SetupAction.ps1 80% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #2066   +/-   ##
====================================
  Coverage    94%     94%           
====================================
  Files        94      95    +1     
  Lines      7926    7993   +67     
====================================
+ Hits       7500    7566   +66     
- Misses      426     427    +1     
Flag Coverage Δ
unit 94% <93%> (+<1%) ⬆️
Files with missing lines Coverage Δ
source/Private/Invoke-SetupAction.ps1 92% <80%> (+1%) ⬆️
source/Private/Invoke-ReportServerSetupAction.ps1 95% <95%> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 8 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)


tests/Unit/Public/Install-SqlDscServer.Tests.ps1 line 656 at r2 (raw file):

        }

        Context 'When specifying sensitive parameter <MockParameterName>' -ForEach @(

This test should be removed here because it testing Invoke-SetupAction which is already tests in its own tests. But can be fixed in a separate PR.

Code quote:

Context 'When specifying sensitive parameter <MockParameterName>' -ForEach @(

tests/Unit/Public/Install-SqlDscServer.Tests.ps1 line 2284 at r2 (raw file):

            }

            Context 'When specifying sensitive parameter <MockParameterName>' -ForEach @(

This test should be removed here because it testing Invoke-SetupAction which is already tests in its own tests. But can be fixed in a separate PR.

Code quote:

Context 'When specifying sensitive parameter <MockParameterName>' -ForEach @(

@johlju johlju merged commit 2246dcd into dsccommunity:main Mar 2, 2025
44 checks passed
@johlju johlju deleted the f/issue-#2010 branch March 2, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant