-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support null value for ServiceAutoStartProvider property of xWebApplication #229
base: main
Are you sure you want to change the base?
Support null value for ServiceAutoStartProvider property of xWebApplication #229
Conversation
c282efe
to
18e20b0
Compare
Hi @fredgate - Yes, a unit test would be great. If you want to check out our TestGuidelines that should get you started. You can just add it in to the existing xWebApplication tests. Thanks! |
Would be nice also to be able to clear |
Hi @fredgate are you still working on this? Happy to help if needed. |
Passing
|
@fredgate are you still able to work on this pull request? If so I can help you review it and get it merged. There are merge conflicts and we should have tests that test this scenario. If you can't work on this pull request, no worries, then I will label it as abandoned so that someone else can take over the work. 🙂 |
Labeling this PR as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again. |
I open this pull request to follow my work to fix the issue #225.
The goal is that xWebApplication resource provide the avibility to remove ServiceAutoStartProvider already configured for a web application in IIS.
I actually remove the property for the web application. Could I have a feedback (about logic, readability...) on the pushed commit ?
I think that a unit test should be added to validate this case, but I don't know exactly what and how to do. Some help for this shoud be appreciate.
Surely should we also remove the provider of the web application from IIS's providers list if no other application references this provider. What do you think ?
This change is