Skip to content

Commit

Permalink
Merge pull request #57 from dsccommunity/dev
Browse files Browse the repository at this point in the history
Prepare to remove Dev Branch
  • Loading branch information
PlagueHO authored May 9, 2020
2 parents 2208ad2 + d3c43f8 commit ca2f88c
Show file tree
Hide file tree
Showing 58 changed files with 3,171 additions and 1,291 deletions.
12 changes: 0 additions & 12 deletions .MetaTestOptIn.json

This file was deleted.

26 changes: 0 additions & 26 deletions .codecov.yml

This file was deleted.

10 changes: 10 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
###############################################################################
# Set default behavior to automatically normalize line endings.
###############################################################################
* text eol=crlf

# Ensure any exe files are treated as binary
*.exe binary
*.jpg binary
*.xl* binary
*.pfx binary
11 changes: 10 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
DSCResource.Tests
*.suo
*.user
*.coverage
.vs
.vscode
.psproj
.sln
markdownissues.txt
output/

15 changes: 3 additions & 12 deletions .vscode/analyzersettings.psd1
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
@{
<#
For the custom rules to work, the DscResource.Tests repo must be
cloned. It is automatically clone as soon as any unit or
integration tests are run.
#>
CustomRulePath = '.\DSCResource.Tests\DscResource.AnalyzerRules'

CustomRulePath = '.\output\RequiredModules\DscResource.AnalyzerRules'
includeDefaultRules = $true
IncludeRules = @(
# DSC Resource Kit style guideline rules.
'PSAvoidDefaultValueForMandatoryParameter',
Expand Down Expand Up @@ -43,11 +38,7 @@
'PSUseDeclaredVarsMoreThanAssignments',
'PSUsePSCredentialType',

<#
This is to test all the DSC Resource Kit custom rules.
The name of the function-blocks of each custom rule start
with 'Measure*'.
#>
'Measure-*'
)

}
29 changes: 26 additions & 3 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,38 @@
// Place your settings in this file to overwrite default and user settings.
{
"powershell.codeFormatting.openBraceOnSameLine": false,
"powershell.codeFormatting.newLineAfterOpenBrace": false,
"powershell.codeFormatting.newLineAfterOpenBrace": true,
"powershell.codeFormatting.newLineAfterCloseBrace": true,
"powershell.codeFormatting.whitespaceBeforeOpenBrace": true,
"powershell.codeFormatting.whitespaceBeforeOpenParen": true,
"powershell.codeFormatting.whitespaceAroundOperator": true,
"powershell.codeFormatting.whitespaceAfterSeparator": true,
"powershell.codeFormatting.ignoreOneLineBlock": false,
"powershell.codeFormatting.pipelineIndentationStyle": "IncreaseIndentationAfterEveryPipeline",
"powershell.codeFormatting.preset": "Custom",
"powershell.codeFormatting.alignPropertyValuePairs": true,
"files.trimTrailingWhitespace": true,
"files.insertFinalNewline": true,
"powershell.scriptAnalysis.settingsPath": ".vscode\\analyzersettings.psd1"
"powershell.scriptAnalysis.settingsPath": ".vscode\\analyzersettings.psd1",
"powershell.scriptAnalysis.enable": true,
"files.associations": {
"*.ps1xml": "xml"
},
"cSpell.words": [
"COMPANYNAME",
"ICONURI",
"LICENSEURI",
"PROJECTURI",
"RELEASENOTES",
"buildhelpers",
"endregion",
"gitversion",
"icontains",
"keepachangelog",
"notin",
"pscmdlet",
"steppable"
],
"[markdown]": {
"files.encoding": "utf8"
}
}
50 changes: 43 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,26 @@
# Versions
# Change log for ComputerManagementDsc

## 1.5.1.0
The format is based on and uses the types of changes according to [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Changed

- Transferred ownership to DSCCommunity.org - Fixes [Issue #50](https://github.com/dsccommunity/iSCSIDsc/issues/50).
- Fix hash table style guideline violations.
- Added .gitattributes file to fix bug publishing examples - Fixes [Issue #40](https://github.com/PlagueHO/iSCSIDsc/issues/40).
- Opted into Common Tests 'Common Tests - Validate Localization' - Fixes [Issue #44](https://github.com/PlagueHO/iSCSIDsc/issues/44).
- Renamed `iSCSIDsc.ResourceHelpers` module to `iSCSIDsc.Common`
to align to other modules.
- Renamed all localization strings so that they are detected by
'Common Tests - Validate Localization'.
- Fixed issues with mismatched localization strings.
- Replaced `iSCSIDsc.Common` module with the latest version from
[DSCResource.Template](https://github.com/PowerShell/DSCResource.Template).
- Fix minor style issues in statement case.
- Fix minor style issues in hashtable layout.
- Correct other minor style issues.
- Enabled PSSA rule violations to fail build - Fixes [Issue #27](https://github.com/PlagueHO/iSCSIDsc/issues/27).
- Updated tests to meet Pester v4 standard.
- Added Open Code of Conduct.
Expand All @@ -16,28 +35,45 @@
- Common Tests - Relative Path Length
- Update to new format LICENSE.
- Added .VSCode settings for applying DSC PSSA rules - fixes [Issue #37](https://github.com/PlagueHO/iSCSIDsc/issues/37).
- BREAKING CHANGE: Changed resource prefix from MSFT to DSC.
- Updated to use continuous delivery pattern using Azure DevOps - fixes
[Issue #52](https://github.com/dsccommunity/iSCSIDsc/issues/52).
- Update build badges in `README.md` with correct build IDs.
- Removed unused test helper function `New-VDisk`.
- Added test helper function `Assert-CanRunIntegrationTest` to validate if
integration tests can be successfully run on a machine.

## 1.5.0.0
## [1.5.0.41] - 2017-09-02

### Changed

- Converted resource module to be compliant with HQRM.
- Changed AppVeyor.yml to use AppVeyor module.
- Converted to Autodocumentation module.

## 1.2.1.0
## [1.2.1.95] - 2016-05-04

### Changed

- iSCSIInitiator: Fix bug when converting connected target to IsPersistent.

## 1.2.0.0
## [1.2.0.0] - 2016-01-01

### Changed

- iSCSIInitiator:
- Fix bug when TargetPortalAddress is set to a Hostname instead of an IP address.
- InitiatorPortalAddress property made optional.
- Unit and Integration test headers updated to v1.1.0

## 1.1.0.0
## [1.1.0.0] - 2016-01-01

### Changed

- Added iSNS Server support.

## 1.0.0.0
## [1.0.0.0] - 2016-01-01

### Changed

- Initial release.
134 changes: 2 additions & 132 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -1,133 +1,3 @@
# Open Source Code of Conduct
# Code of Conduct

This code of conduct outlines our expectations for participants within this
DSC Resource Module community, as well as steps to reporting unacceptable behavior.
We are committed to providing a welcoming and inspiring community for all and expect
our code of conduct to be honored. Anyone who violates this code of conduct may be
banned from the community.

Our open source communities strive to:

- **Be friendly and patient.**
- **Be welcoming:** We strive to be a community that welcomes and supports people
of all backgrounds and identities. This includes, but is not limited to members
of any race, ethnicity, culture, national origin, colour, immigration status,
social and economic class, educational level, sex, sexual orientation, gender
identity and expression, age, size, family status, political belief, religion,
and mental and physical ability.
- **Be considerate:** Your work will be used by other people, and you in turn
will depend on the work of others. Any decision you take will affect users and
colleagues, and you should take those consequences into account when making
decisions. Remember that we're a world-wide community, so you might not be
communicating in someone else's primary language.
- **Be respectful:** Not all of us will agree all the time, but disagreement is
no excuse for poor behavior and poor manners. We might all experience some
frustration now and then, but we cannot allow that frustration to turn into a
personal attack. It's important to remember that a community where people feel
uncomfortable or threatened is not a productive one.
- **Be careful in the words that we choose:** we are a community of professionals,
and we conduct ourselves professionally. Be kind to others. Do not insult or
put down other participants. Harassment and other exclusionary behavior aren't
acceptable.
- **Try to understand why we disagree:** Disagreements, both social and technical,
happen all the time. It is important that we resolve disagreements and differing
views constructively. Remember that we're different. The strength of our community
comes from its diversity, people from a wide range of backgrounds. Different people
have different perspectives on issues. Being unable to understand why someone holds
a viewpoint doesn't mean that they're wrong. Don't forget that it is human to err
and blaming each other doesn't get us anywhere. Instead, focus on helping to resolve
issues and learning from mistakes.

## Definitions

Harassment includes, but is not limited to:

- Offensive comments related to gender, gender identity and expression, sexual
orientation, disability, mental illness, neuro(a)typicality, physical appearance,
body size, race, age, regional discrimination, political or religious affiliation
- Unwelcome comments regarding a person's lifestyle choices and practices,
including those related to food, health, parenting, drugs, and employment
- Deliberate misgendering. This includes deadnaming or persistently using a
pronoun that does not correctly reflect a person's gender identity. You must
address people by the name they give you when not addressing them by their username
or handle
- Physical contact and simulated physical contact (eg, textual descriptions like
"hug" or "backrub") without consent or after a request to stop
- Threats of violence, both physical and psychological
- Incitement of violence towards any individual, including encouraging a person
to commit suicide or to engage in self-harm
- Deliberate intimidation
- Stalking or following
- Harassing photography or recording, including logging online activity for
harassment purposes
- Sustained disruption of discussion
- Unwelcome sexual attention, including gratuitous or off-topic sexual images or
behaviour
- Pattern of inappropriate social contact, such as requesting/assuming inappropriate
levels of intimacy with others
- Continued one-on-one communication after requests to cease
- Deliberate "outing" of any aspect of a person's identity without their consent
except as necessary to protect others from intentional abuse
- Publication of non-harassing private communication

Our open source community prioritizes marginalized people's safety over privileged
people's comfort. We will not act on complaints regarding:

- 'Reverse' -isms, including 'reverse racism,' 'reverse sexism,' and 'cisphobia'
- Reasonable communication of boundaries, such as "leave me alone," "go away," or
"I'm not discussing this with you"
- Refusal to explain or debate social justice concepts
- Communicating in a 'tone' you don't find congenial
- Criticizing racist, sexist, cissexist, or otherwise oppressive behavior or assumptions

## Diversity Statement

We encourage everyone to participate and are committed to building a community
for all. Although we will fail at times, we seek to treat everyone both as fairly
and equally as possible. Whenever a participant has made a mistake, we expect them
to take responsibility for it. If someone has been harmed or offended, it is our
responsibility to listen carefully and respectfully, and do our best to right the
wrong.

Although this list cannot be exhaustive, we explicitly honor diversity in age,
gender, gender identity or expression, culture, ethnicity, language, national
origin, political beliefs, profession, race, religion, sexual orientation, socioeconomic
status, and technical ability. We will not tolerate discrimination based on any
of the protected characteristics above, including participants with disabilities.

## Reporting Code of Conduct Issues

If you experience or witness unacceptable behavior—or have any other concerns,
please report it by contacting us via [[email protected]](mailto:[email protected]).
All reports will be handled with discretion.

In your report please include:

- Your contact information.
- Names (real, usernames or pseudonyms) of any individuals involved. If there
are additional witnesses, please include them as well.
- Your account of what occurred, and if you believe the incident is ongoing.
- If there is a publicly available record (e.g. a mailing list archive or a
public chat log), please include a link or attachment.
- Any additional information that may be helpful.

After filing a report, a representative will contact you personally, review the
incident, follow up with any additional questions, and make a decision as to how
to respond. If the person who is harassing you is part of the response team, they
will recuse themselves from handling your incident. If the complaint originates
from a member of the response team, it will be handled by a different member of
the response team. We will respect confidentiality requests for the purpose of
protecting victims of abuse.

## Attribution & Acknowledgements

We all stand on the shoulders of giants across many open source communities.
We’d like to thank the communities and projects that established code of conducts
and diversity statements as our inspiration:

- [Django](https://www.djangoproject.com/conduct/reporting/)
- [Python](https://www.python.org/community/diversity/)
- [Ubuntu](http://www.ubuntu.com/about/about-ubuntu/conduct)
- [Contributor Covenant](http://contributor-covenant.org/)
- [Geek Feminism](http://geekfeminism.org/about/code-of-conduct/)
- [Citizen Code of Conduct](http://citizencodeofconduct.org/)
This project has adopted the [DSC Community Code of Conduct](https://dsccommunity.org/code_of_conduct).
26 changes: 26 additions & 0 deletions GitVersion.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
mode: ContinuousDelivery
next-version: 1.5.0
major-version-bump-message: '\s?(breaking|major|breaking\schange)'
minor-version-bump-message: '\s?(add|feature|minor)'
patch-version-bump-message: '\s?(fix|patch)'
no-bump-message: '\+semver:\s?(none|skip)'
assembly-informational-format: '{NuGetVersionV2}+Sha.{Sha}.Date.{CommitDate}'
branches:
master:
tag: preview
pull-request:
tag: PR
feature:
tag: useBranchName
increment: Minor
regex: f(eature(s)?)?[\/-]
source-branches: ['master']
hotfix:
tag: fix
increment: Patch
regex: (hot)?fix(es)?[\/-]
source-branches: ['master']

ignore:
sha: []
merge-message-formats: {}
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (c) Daniel Scott-Raynsford. All rights reserved.
Copyright the DSC Community contributors. All rights reserved.

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
Loading

0 comments on commit ca2f88c

Please sign in to comment.