Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-xDscResource: Change Dsc Module Validate Set Quotes to Singles #83

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Sep 16, 2019

Pull Request (PR) description

This PR changes the quotes used around validate set values to be single quotes instead of double quotes to conform to Dsc Resource Style Guidelines

This Pull Request (PR) fixes the following issues

None

Task list

  • Added an entry under the Unreleased section of the change log in the README.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Unit tests added/updated.
  • New/changed code adheres to
    DSC Resource Style Guidelines
    and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Sep 16, 2019

Codecov Report

Merging #83 into dev will increase coverage by 1.11%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #83      +/-   ##
==========================================
+ Coverage   61.26%   62.38%   +1.11%     
==========================================
  Files           1        1              
  Lines         994      997       +3     
  Branches        3        3              
==========================================
+ Hits          609      622      +13     
+ Misses        382      372      -10     
  Partials        3        3
Impacted Files Coverage Δ
xDSCResourceDesigner.psm1 62.38% <75%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492834e...1936b00. Read the comment docs.

@X-Guardian X-Guardian marked this pull request as ready for review September 16, 2019 19:57
@johlju johlju added the needs review The pull request needs a code review. label Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants