xGroup: prohibit NewName for not-existing group

Don’t allow the NewName parameter to set SamAccountName when creating an entirely new gorup.
dsccommunity · May 23, 2021 · e08dece · e08dece
1 parent f65353d
commit e08dece
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/source/DSCResources/DSC_xGroupResource/DSC_xGroupResource.psm1 b/source/DSCResources/DSC_xGroupResource/DSC_xGroupResource.psm1
@@ -621,6 +621,15 @@ function Set-TargetResourceOnFullSKU
 
                 if (-not $groupOriginallyExists)
                 {
+                    foreach ($incompatibleParameterName in @( 'NewName' ))
+                    {
+                        if ($PSBoundParameters.ContainsKey($incompatibleParameterName))
+                        {
+                            New-InvalidArgumentException -ArgumentName $incompatibleParameterName `
+                                -Message ($script:localizedData.NewGroupNewNameConflict -f 'NewName', $incompatibleParameterName)
+                        }
+                    }
+
                     $localPrincipalContext = Get-PrincipalContext -PrincipalContextCache $principalContextCache `
                         -Disposables $disposables -Scope $env:COMPUTERNAME
 

diff --git a/source/DSCResources/DSC_xGroupResource/en-US/DSC_xGroupResource.strings.psd1 b/source/DSCResources/DSC_xGroupResource/en-US/DSC_xGroupResource.strings.psd1
@@ -12,6 +12,7 @@ ConvertFrom-StringData @'
     NoConfigurationRequiredGroupDoesNotExist = Group {0} does not exist on this node. No action required.
     CouldNotFindPrincipal = Could not find a principal with the provided name {0}.
     MembersAndIncludeExcludeConflict = The {0} and {1} parameters conflict. The {0} parameter should not be used in any combination with the {1} parameter.
+    NewGroupNewNameConflict = The {0} parameter cannot be used when creating a new group.
     GroupAndMembersEmpty = Members is empty and group {0} has no members. No change to group members is needed.
     MemberIsNotALocalUser = {0} is not a local user. User's principal source is {1}.
     MemberNotValid = The group member {0} does not exist or cannot be resolved.