-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto support & fix appveyor build #16
base: dev
Are you sure you want to change the base?
Conversation
@kewalaka Sorry that it took so long for someone to review this. If I review this one, do you have time to work on it? |
hi @johlju I want to say yes but honestly would struggle. i know this resource needs a lot of work to get it to standard based on what ive seen elsewhere and it's one I have little use for. xcopy so much easier when it's practical! |
The biggest issue is to get tests for this. It looks like we could build an integration tests for this, but this resource module does not even have unit tests, so this could should at least be tested with unit tests. But would love to have an integration tests for the composite resource. It sounds like you won't have the time to put in the work to continue this PR, so I will label this as abandoned. If you do want to continue working on this, just say so I and I will relabel it as 'waiting for code fix'. Note for myself: I have not reviewed the code yet. Just some of the simpler changes. Review status: 3 of 7 files reviewed at latest revision, all discussions resolved. ResourceSetHelper.psm1, line 1 at r1 (raw file):
We should add tests for this, could the tests in PSDscResource be copied in? DSCResources/xWebDeploy/xWebDeploy.Schema.psm1, line 2 at r1 (raw file):
We should have an integration test that test this - maybe xWebAdministration could be an inspiration for how to accomplish this. Comments from Reviewable |
This addresses issues #14 and #15
This change is