Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate sem change to Remote Config, Levelling of the repository with the play store version and minor fixes #205

Merged
merged 5 commits into from
Apr 29, 2021

Conversation

nayakastha
Copy link
Member

@nayakastha nayakastha commented Apr 12, 2021

Description

This pull request is for -

  • Migrating the semester change process to remote config.
  • Correcting the mismatch between the repository and the play store version.
  • Fixing the navigation issue ( the app was crashing on returning back to the home screen from the appointment screen).
  • Restructuring the file structure to avoid future confusions.

@github-actions
Copy link

image image
Hello @nayakastha , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@github-actions
Copy link

image image
Hello @nayakastha , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@nayakastha nayakastha changed the title levelling of play store version and repo Transfer of Sem Change to Remote Config Apr 12, 2021
@github-actions
Copy link

image image
Hello @nayakastha , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@abhibhaw abhibhaw linked an issue Apr 12, 2021 that may be closed by this pull request
@abhibhaw abhibhaw self-requested a review April 12, 2021 20:25
@DesignrKnight DesignrKnight changed the title Transfer of Sem Change to Remote Config Setup Remote Config for Sem Change Apr 15, 2021
@DesignrKnight
Copy link
Member

@nayakastha
It is better if you always write description for the PR

Copy link
Member

@DesignrKnight DesignrKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that there are a lot of file renames and many other such changes that are irrelevant to the PR. Why did that happen?

scp/android/app/build.gradle Show resolved Hide resolved
scp/lib/login.dart Show resolved Hide resolved
@nayakastha
Copy link
Member Author

I see that there are a lot of file renames and many other such changes that are irrelevant to the PR. Why did that happen?

The WOC Codes are repeated codes and have not been implemented yet. So them being stored along with the initial files created a tad bit of confusion. So arranged it within the correct folder for Stacked Architecture

@DesignrKnight
Copy link
Member

I would suggest to update the PR title as it is not just Remote Config but much more than that

@nayakastha nayakastha changed the title Setup Remote Config for Sem Change Migrate sem change to Remote Config, Levelling of the repository with the play store version and minor fixes Apr 15, 2021
@nayakastha
Copy link
Member Author

@DesignrKnight review this PR if possible.

@SriramPatibanda SriramPatibanda merged commit 577f48b into dscnitrourkela:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants