Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slow Connectivity Crash #43

Closed
wants to merge 1 commit into from

Conversation

ferquies
Copy link

@ferquies ferquies commented Oct 3, 2019

Add a function to check the internet availability and use it before make any network calls

#38

Add a function to check the internet availability and use it before make any network calls
Copy link
Member

@Chinmay-KB Chinmay-KB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so there are a few places where we need an active internet connection

FAQ
Book your appointment
Mentors
It would be nice if you could check for internet connection everywhere.
Also, display an appropriate snackbar notifying the user of the inactive internet connection.

I'd recommend you to rather implement the internet connectivity logic on the flutter side than in native, so that implementing the snackbar is easier for you

@ferquies
Copy link
Author

ferquies commented Oct 4, 2019

Ok, I keep working on it

@DesignrKnight DesignrKnight changed the title Fix Issue #38 Fix Slow Connectivity Crash Oct 4, 2019
@DesignrKnight
Copy link
Member

Any update?

@ferquies
Copy link
Author

Sorry, I'd wrote a comment with doubts in the issue section and I think you didn't saw, I paste it here:
Ok, in Mentors section there are actually a button that indicates there is no internet connection. Did you mean we must show the "No internet connection" snackbar before open any section that needs internet or implement the snackbar inside each section?
And in case we must show the snackbar inside each screen, in the case of FAQ I have to show it in native.

@DesignrKnight
Copy link
Member

A uniform snack-bar in all route/activity that shows no connectivity in case of lack of internet access is what we are expecting as an ideal solution.

@ferquies
Copy link
Author

I maked another pull request at #51

@ferquies ferquies closed this Oct 17, 2019
@ferquies ferquies deleted the faq-patch-1 branch October 17, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants