Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update board member card look and feel #103

Closed
wants to merge 1 commit into from
Closed

Update board member card look and feel #103

wants to merge 1 commit into from

Conversation

Aditya-Jyoti
Copy link
Contributor

πŸ› οΈ Fixes Issue: Closes #102

πŸ‘¨β€πŸ’» Changes proposed

Proposed an update in the look of Board Member cards and made use of previously unused parameters

πŸ”§ Check List (Check the type of issue it fixes)

  • Bug Fix
  • New Extension
  • Enhancement
  • Documentation

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have done git pull before adding my new changes
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

πŸ“· Screenshots

Screenshot 2023-10-02 210811

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
dscvitchennai βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 2, 2023 4:41pm

@Aditya-Jyoti
Copy link
Contributor Author

@EmmanuelAllanMJ @vaibhavTekk could you review this PR

@EmmanuelAllanMJ
Copy link
Member

Can you update the names and their designation, use dummy data if not provided

@vaibhavTekk
Copy link
Member

@Aditya-Jyoti just to clarify, this just updates the components and not the data correct ?

@Aditya-Jyoti
Copy link
Contributor Author

Will push with dummy data once I'm back from class in another PR. This one was just for the CSS updates

@Aditya-Jyoti
Copy link
Contributor Author

@Aditya-Jyoti just to clarify, this just updates the components and not the data correct ?

Yes, just updates the components

@vaibhavTekk
Copy link
Member

@Aditya-Jyoti There's some overlap between the image and the text, can you make it so that all the images show up with the same width and height ?

image

@Aditya-Jyoti
Copy link
Contributor Author

@Aditya-Jyoti There's some overlap between the image and the text, can you make it so that all the images show up with the same width and height ?

image

I faced the same issue when working with the date. The easiest method to solve it is to crop all images inside the public/leads/ folder to a square format.

I chose the manual method because for some reason setting the witdh and height as well as the padding gave inconsistent results.

I'll make cropping changes once I'm back from class

@Aditya-Jyoti
Copy link
Contributor Author

closing this PR, will open a new one with all the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve Board Member cards
3 participants